Skip to content

Conversation

@lymereJ
Copy link
Collaborator

@lymereJ lymereJ commented Apr 17, 2025

Pull request overview

Add new inputs/outputs to model air leakage in parallel fan-powered terminal units.

Pull Request Author

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If structural output changes, add to output rules file and add OutputChange label

Reviewer

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@lymereJ lymereJ added NewFeature Includes code to add a new feature to EnergyPlus IDDChange Code changes impact the IDD file (cannot be merged after IO freeze) OutputChange Code changes output in such a way that it cannot be merged after IO freeze labels Apr 17, 2025
@NatLabRockies NatLabRockies deleted a comment from github-actions bot Apr 17, 2025
@NatLabRockies NatLabRockies deleted a comment from github-actions bot Apr 28, 2025
@NatLabRockies NatLabRockies deleted a comment from github-actions bot Apr 28, 2025
@NatLabRockies NatLabRockies deleted a comment from github-actions bot Apr 28, 2025
@mjwitte
Copy link
Contributor

mjwitte commented Sep 25, 2025

@lymereJ Is this targeted for 25.2?

@lymereJ
Copy link
Collaborator Author

lymereJ commented Sep 26, 2025

@mjwitte - Ideally, yes, but it's not quite ready. I'm hoping to be able to get back to it sometime next week.

@lymereJ lymereJ added this to the EnergyPlus 25.2 IO Freeze milestone Sep 26, 2025
@lymereJ lymereJ force-pushed the parallel_piu_leakage branch from d7d35c6 to 4254b29 Compare October 10, 2025 18:15
@lymereJ lymereJ added this to the EnergyPlus 26.1 milestone Nov 19, 2025
@NatLabRockies NatLabRockies deleted a comment from github-actions bot Dec 19, 2025
@NatLabRockies NatLabRockies deleted a comment from github-actions bot Dec 19, 2025
@NatLabRockies NatLabRockies deleted a comment from nrel-bot-2c Dec 19, 2025
@NatLabRockies NatLabRockies deleted a comment from github-actions bot Dec 19, 2025
@NatLabRockies NatLabRockies deleted a comment from github-actions bot Dec 19, 2025
@NatLabRockies NatLabRockies deleted a comment from github-actions bot Dec 19, 2025
@NatLabRockies NatLabRockies deleted a comment from github-actions bot Dec 19, 2025
@NatLabRockies NatLabRockies deleted a comment from github-actions bot Dec 19, 2025
@NatLabRockies NatLabRockies deleted a comment from github-actions bot Dec 19, 2025
@NatLabRockies NatLabRockies deleted a comment from nrel-bot-2 Dec 19, 2025
@NatLabRockies NatLabRockies deleted a comment from github-actions bot Dec 19, 2025
@NatLabRockies NatLabRockies deleted a comment from github-actions bot Dec 19, 2025
Copy link
Collaborator

@rraustad rraustad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mitchute this looks good overall for a new feature.

@github-actions
Copy link

⚠️ Regressions detected on ubuntu-24.04 for commit b787772

Regression Summary
  • Audit: 4
  • RDD: 4

@github-actions
Copy link

⚠️ Regressions detected on macos-14 for commit b787772

Regression Summary
  • Audit: 4
  • RDD: 4

@NatLabRockies NatLabRockies deleted a comment from github-actions bot Jan 21, 2026
@NatLabRockies NatLabRockies deleted a comment from github-actions bot Jan 21, 2026
@NatLabRockies NatLabRockies deleted a comment from github-actions bot Jan 21, 2026
@NatLabRockies NatLabRockies deleted a comment from github-actions bot Jan 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

IDDChange Code changes impact the IDD file (cannot be merged after IO freeze) NewFeature Includes code to add a new feature to EnergyPlus OutputChange Code changes output in such a way that it cannot be merged after IO freeze

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants