SDR: HPRTU measure: setting fan max flow the same as coil rated flow#351
Open
JanghyunJK wants to merge 4 commits intomainfrom
Open
SDR: HPRTU measure: setting fan max flow the same as coil rated flow#351JanghyunJK wants to merge 4 commits intomainfrom
JanghyunJK wants to merge 4 commits intomainfrom
Conversation
e63af0e to
4ffef0e
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses an issue where HPRTU models had mismatched airflow rates between the coil rated flow and variable fan maximum flow, causing simulation errors. The fix ensures these values are properly aligned to prevent EnergyPlus warnings and errors.
- Sets fan maximum flow rate to match the highest stage flow rate from cooling or heating
- Adds unit test to verify airflow rates are consistent between fan and unitary system components
- Includes code style improvements and cleanup in test files
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| measure.rb | Added logic to set fan maximum flow rate to match the highest stage flow rate |
| measure_test.rb | Added unit test to verify airflow consistency and various code style improvements |
| measure.xml | Updated version ID and checksums to reflect code changes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
7cf2a5c to
27f45bc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request overview
@ChristopherCaradonna targeting this to be reflected in the next release
Pull Request Author
This pull request makes changes to (select all the apply):
Author pull request checklist:
comstock_column_definitions.csvoptions_lookup.tsvfiles updated.ymlfilesREADME.mdfilestest/reporting_measure_tests.txt,test/workflow_measure_tests.txt, ortest/upgrade_measure_tests.txtReview Checklist
This will not be exhaustively relevant to every PR.