Fix CUDA compilation with Windows MSVC #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Windows-specific nvcc flags to fix the build: - `-Xcompiler /Zc:preprocessor`: Enables MSVC's standards-conformant C/C++ preprocessor, which correctly handles complex macro patterns in Windows SDK headers like oaidl.h. - `-DNOGDI`: Excludes GDI definitions from Windows headers, preventing wingdi.h's CC_MSCPASCAL macro from conflicting with the enum of the same name in oaidl.h.
Author
|
This is what allowed compilation on my machine. Could use someone else to double check if this is necessary. I'm also willing to try any other suggestions in case this patch isn't satisfactory. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Windows-specific nvcc flags to fix the build:
-Xcompiler /Zc:preprocessor: Enables MSVC's standards-conformant C/C++ preprocessor, which correctly handles complex macro patterns in Windows SDK headers like oaidl.h.-DNOGDI: Excludes GDI definitions from Windows headers, preventing wingdi.h's CC_MSCPASCAL macro from conflicting with the enum of the same name in oaidl.h.