-
Notifications
You must be signed in to change notification settings - Fork 17
Support build cubin & Add unittest #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@Narsil @ivarflakstad This PR is designed to enable precompilation of Cubin for loading on Candle. The support for CUDARC has been completed (chelsea0x3b/cudarc#505). If possible, could you please help review the PR. Thank you very much |
|
@haricot @ivarflakstad Fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved: tested locally with:
NVCC_CCBIN="gcc-14" cargo test --test build_cubin_test -- --nocapture --> OK
Thank you!
Reflection on another PR topic: We could add support for a CUDA_ROOT_LEGACY or NVCC_BIN variable to be able to point to a legacy CUDA root or a specific nvcc binary (useful when the driver is newer than nvcc. ex: driver cuda_13.0 vs nvcc 12.9).
Support build cubin & Add unittest
This pull PR provides support for compiling cubin with bindgen_cuda. In some cases, it is necessary to directly compile cubin through bindgen_cuda, so support has been added, ensuring backward compatibility, and unit tests as well as the compilation of cubin on candle-kernel have all passed.
Test Result
Unit test
Test in candle-kernel build cubin