-
Notifications
You must be signed in to change notification settings - Fork 6
[prod] 0.7.0 #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[prod] 0.7.0 #86
Conversation
…ies and enhance error handling
…ng animation handling
…d update exports in core and player modules
…e for improved notification handling
…y changes across the player
narraleaf-react-0.7.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Skip Key Handling Interferes with Navigation
The (!router || !router.isActive()) condition was removed from the skip key handling logic. This change allows skip actions to occur even when the router or menu system is active, leading to unintended skipping during page transitions, navigation, or menu interactions, and disrupting the user experience.
src/game/player/elements/player/KeyEventAnnouncer.tsx#L47-L50
narraleaf-react/src/game/player/elements/player/KeyEventAnnouncer.tsx
Lines 47 to 50 in 0238225
| const handleKeyDown = (event: KeyboardEvent) => { | |
| if (game.keyMap.match(KeyBindingType.skipAction, event.key) | |
| && game.preference.getPreference(Game.Preferences.skip) | |
| ) { |
BugBot free trial expires on July 22, 2025
You have used $0.00 of your $50.00 spend limit so far. Manage your spend limit in the Cursor dashboard.
Was this report helpful? Give feedback by reacting with 👍 or 👎
No description provided.