fix: preserve runtimeStateDelta after chapter content normalization#149
Open
tank7155611 wants to merge 1 commit intoNarcooo:masterfrom
Open
fix: preserve runtimeStateDelta after chapter content normalization#149tank7155611 wants to merge 1 commit intoNarcooo:masterfrom
tank7155611 wants to merge 1 commit intoNarcooo:masterfrom
Conversation
Author
|
#146 |
When chapter content is normalized or revised (finalContent !== output.content), buildPersistenceOutput calls analyzeChapter whose output may not include runtimeStateDelta. This caused chapter_summaries.json to not be updated, making the planner repeat the previous chapter plot events on the next write. Also fix mustAdvance hook sort direction (ascending, not descending) so that the most neglected hooks are surfaced first.
tank7155611
force-pushed
the
fix/preserve-runtime-delta-after-normalization
branch
from
b1b1c08 to
eb59f76
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When chapter content is normalized or revised (finalContent !== output.content),
buildPersistenceOutput calls analyzeChapter whose output may not include
runtimeStateDelta. This caused chapter_summaries.json to not be updated,
making the planner repeat the previous chapter plot events on the next write.
Also fix mustAdvance hook sort direction (ascending, not descending) so that
the most neglected hooks are surfaced first.
Summary
Type of change
Motivation (optional)
Changes
Usage (optional)
Test plan
pnpm typecheckpassespnpm testpasses (all existing + new tests)Breaking changes (optional)