Skip to content

fix: StateValidatorAgent graceful error handling instead of throwing #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pzysvip99999 wants to merge 2 commits into
base: master
Choose a base branch
from
+72 −61
Open

fix: StateValidatorAgent graceful error handling instead of throwing #134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a1a906
fix: wrap validateRuntimeState in try-catch to prevent JSON parse err…
Mar 31, 2026
b67f52a
fix: StateValidatorAgent returns graceful result on parse/validation …
Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/core/src/agents/state-validator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ ${chapterContent.slice(0, 6000)}`;
return this.parseResult(response.content);
} catch (error) {
this.log?.warn(`State validation failed: ${error}`);
throw error;
return { warnings: [{ category: "validator_error", description: String(error) }], passed: true };
}
}

Expand Down Expand Up @@ -145,7 +145,8 @@ ${chapterContent.slice(0, 6000)}`;
passed: parsed.passed,
};
} catch (error) {
throw new Error(`State validator returned invalid response: ${String(error)}`);
this.log?.warn(`StateValidatorAgent.parseResult failed: ${error}`);
return { warnings: [{ category: "validator_error", description: String(error) }], passed: true };
}
}
}
Expand Down
128 changes: 69 additions & 59 deletions packages/core/src/state/state-validator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,74 +17,84 @@ export function validateRuntimeState(input: {
readonly hooks: unknown;
readonly chapterSummaries: unknown;
}): RuntimeStateValidationIssue[] {
const issues: RuntimeStateValidationIssue[] = [];
try {
const issues: RuntimeStateValidationIssue[] = [];

const manifest = parseOrIssue(
StateManifestSchema,
input.manifest,
issues,
"invalid_manifest",
"manifest",
);
const currentState = parseOrIssue(
CurrentStateStateSchema,
input.currentState,
issues,
"invalid_current_state",
"currentState",
);
const hooks = parseOrIssue(
HooksStateSchema,
input.hooks,
issues,
"invalid_hooks_state",
"hooks",
);
const chapterSummaries = parseOrIssue(
ChapterSummariesStateSchema,
input.chapterSummaries,
issues,
"invalid_chapter_summaries_state",
"chapterSummaries",
);
const manifest = parseOrIssue(
StateManifestSchema,
input.manifest,
issues,
"invalid_manifest",
"manifest",
);
const currentState = parseOrIssue(
CurrentStateStateSchema,
input.currentState,
issues,
"invalid_current_state",
"currentState",
);
const hooks = parseOrIssue(
HooksStateSchema,
input.hooks,
issues,
"invalid_hooks_state",
"hooks",
);
const chapterSummaries = parseOrIssue(
ChapterSummariesStateSchema,
input.chapterSummaries,
issues,
"invalid_chapter_summaries_state",
"chapterSummaries",
);

if (hooks) {
const seen = new Set<string>();
for (const hook of hooks.hooks) {
if (seen.has(hook.hookId)) {
issues.push({
code: "duplicate_hook_id",
message: `duplicate hook id: ${hook.hookId}`,
path: `hooks.${hook.hookId}`,
});
if (hooks) {
const seen = new Set<string>();
for (const hook of hooks.hooks) {
if (seen.has(hook.hookId)) {
issues.push({
code: "duplicate_hook_id",
message: `duplicate hook id: ${hook.hookId}`,
path: `hooks.${hook.hookId}`,
});
}
seen.add(hook.hookId);
}
seen.add(hook.hookId);
}
}

if (chapterSummaries) {
const seen = new Set<number>();
for (const row of chapterSummaries.rows) {
if (seen.has(row.chapter)) {
issues.push({
code: "duplicate_summary_chapter",
message: `duplicate summary chapter: ${row.chapter}`,
path: `chapterSummaries.${row.chapter}`,
});
if (chapterSummaries) {
const seen = new Set<number>();
for (const row of chapterSummaries.rows) {
if (seen.has(row.chapter)) {
issues.push({
code: "duplicate_summary_chapter",
message: `duplicate summary chapter: ${row.chapter}`,
path: `chapterSummaries.${row.chapter}`,
});
}
seen.add(row.chapter);
}
seen.add(row.chapter);
}
}

if (manifest && currentState && currentState.chapter > manifest.lastAppliedChapter) {
issues.push({
code: "current_state_ahead_of_manifest",
message: `current state chapter ${currentState.chapter} exceeds manifest ${manifest.lastAppliedChapter}`,
path: "currentState.chapter",
});
}
if (manifest && currentState && currentState.chapter > manifest.lastAppliedChapter) {
issues.push({
code: "current_state_ahead_of_manifest",
message: `current state chapter ${currentState.chapter} exceeds manifest ${manifest.lastAppliedChapter}`,
path: "currentState.chapter",
});
}

return issues;
return issues;
} catch (error) {
return [
{
code: "validator_crash",
message: String(error),
path: "",
},
];
}
}

function parseOrIssue<T>(
Expand Down