Skip to content

Fix evaluating ATA Error Count: 0 as a warning #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Napsty merged 1 commit into from
Oct 3, 2025
Merged

Fix evaluating ATA Error Count: 0 as a warning #111

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion check_smart.pl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@
# Sep 10, 2024: Claudio Kuenzler - Fix performance data format, missing perfdata in SCSI drives (6.14.3)
# Jan 31, 2025: Tomas Barton - Ignore old age attributes due to its unrealiability. Check ATA error logs (6.15.0)
# Jun 12, 2025: Alexander Kanevskiy - Add usbjmicron devices (6.16.0)
# Oct 3, 2025: Florian Sager - Fix evaluating ATA Error Count: 0 as a warning

use strict;
use Getopt::Long;
Expand Down Expand Up @@ -503,7 +504,9 @@
unless ($opt_skip_error_log) {
if ($line =~ /^ATA Error Count:\s(\d+)\s/) {
my ($attribute_name, $raw_value) = ('ata_errors', $1);
if ( ($warn_list{$attribute_name}) && ($raw_value >= $warn_list{$attribute_name}) ) {
if ( $raw_value == 0) {
next;
} elsif ( ($warn_list{$attribute_name}) && ($raw_value >= $warn_list{$attribute_name}) ) {
warn "(debug) $attribute_name is non-zero ($raw_value)\n\n" if $opt_debug;
push(@warning_messages, "$attribute_name is non-zero ($raw_value)");
escalate_status('WARNING');
Expand Down