[Napster] Support for more jQuery versions#6
Open
karudedios wants to merge 1 commit intoNapster:masterfrom
Open
[Napster] Support for more jQuery versions#6karudedios wants to merge 1 commit intoNapster:masterfrom
karudedios wants to merge 1 commit intoNapster:masterfrom
Conversation
- Removing usage of `.load` - Using a more "vanilla-ish" approach to wait for iFrame loading, since the usage of `load` has changed from jQuery 1.x through jQuery 3.x
BreaGaudioso
pushed a commit
to BreaGaudioso/napster.js
that referenced
this pull request
Nov 28, 2018
point to prod vip to serve the player
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.loadExplanation
Using a more "vanilla-ish" approach to wait for iFrame loading,
since the usage of
loadhas changed from jQuery 1.x throughjQuery 3.x.
Tested the example is still working as intended.