Skip to content

[FEATURE] Rst File Exporter#4

Open
maddy2101 wants to merge 49 commits intoNamelessCoder:masterfrom
maddy2101:master
Open

[FEATURE] Rst File Exporter#4
maddy2101 wants to merge 49 commits intoNamelessCoder:masterfrom
maddy2101:master

Conversation

@maddy2101
Copy link
Copy Markdown

This exporter creates rst file in the form the official TYPO3 documentation requires.

It will skip all version related details.

Anja Leichsenring and others added 30 commits October 1, 2018 11:41
@maddy2101
Copy link
Copy Markdown
Author

I am not sure how to deal with the badges in the readme, as those currently point to my accounts. Please feel free to adjust as you see fit.

@NamelessCoder
Copy link
Copy Markdown
Owner

NamelessCoder commented Oct 9, 2018

The quality of this work is really impressive, I did not expect you to go all-in and add CI and tests! That's super appreciated. I am however hesitant to integrate a separate format - had it not been for the absolutely minimal footprint of the JSON format export I probably wouldn't have added that either but would instead have made it a separate package (I may still do that as a way to eat my own dog food given what I'm about to suggest).

I think we can look at this as three separate things:

  1. The metadata parts - I'm in full agreement here and if you like, I can extract those changes so you don't have to bother with it.
  2. The change to API of the engine - the addition of force flag on root export method. Also in agreement, I have no objections, but should be a separate feature we can clearly mark as breaking (not that I expect anyone has created integrations yet, except for this one here).
  3. The RST exporter itself - which I would very much prefer as a separate package. I volunteer to take care of the maintenance if you prefer it just gets put here on my account, and will definitely make this package use it in suggest regardless where it gets created.

Also referring to my comment on #5 (comment) about a better CLI tool for invoking the generator.

Lastly I hope this doesn't diminish the effort you put into this. I will of course assist with the further work and creation of new package(s). So I guess the bigger questions are if you agree with this suggested packaging strategy and if so, where do we put what?

DanielSiepmann and others added 5 commits February 11, 2019 09:35
…o3-org

TASK: Add disclaimer and introduction
* Remove wrong information, the reference is now auto generated.
* Add info that no version below 9.5 is generated.
* Add info where to find a 6.2 information.
DanielSiepmann and others added 5 commits April 5, 2019 09:46
* Add data type for each argument.
* Add whether the argument is required.
* Add anchor to each argument and ViewHelper, in order to allow
  references to these.
[BUGFIX] Fix casing of package mikey179/vfsstream
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants