Skip to content

Fix rounding issues that appeared with subtask scoring#348

Merged
Holmes98 merged 1 commit intoNZOI:masterfrom
BelgianSalamander:master
Jan 12, 2026
Merged

Fix rounding issues that appeared with subtask scoring#348
Holmes98 merged 1 commit intoNZOI:masterfrom
BelgianSalamander:master

Conversation

@BelgianSalamander
Copy link
Member

This fix should remove weird rounding issues that cropped up with subtask scoring.

For example, a score that should be 58 would sometimes be displayed as 57 since due to floating point imprecision it was stored as 57.99999999 before getting rounded down.

This pull request should remove such issues while minimising any other visible changes (so most scores wouldn't change at all)

@coveralls
Copy link

Coverage Status

coverage: 38.386%. remained the same
when pulling 1175c68 on BelgianSalamander:master
into 6474deb on NZOI:master.

Copy link
Member

@Holmes98 Holmes98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit hacky, but it should be fine for now.

@Holmes98 Holmes98 merged commit 52c657e into NZOI:master Jan 12, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants