Open
Conversation
Some of those gems (especially mini_racer) are very large, and it is useful to be able to skip them. They were already in a commented-out group; restore the group to allow skipping them (they will still be installed by default). Note that putting them in a group will mean they won't be auto-required when config/application.rb calls `Bundler.require(:default, Rails.env)`, but that should be fine. Also remove the old comment "not required in production environments by default" because it is unclear/inaccurate (we currently run the asset precompilation on the production server), and add hints on how to skip the group.
Was previously openjdk-8-jdk. - yui-compressor only requires the JRE, not the full JDK - GUI libraries aren't required, headless version is enough - the JRE version doesn't really matter, use the default so it gets automatically updated
The lines were copied from script/install/imagemagick.bash and are irrelevant.
They are not required for running the tests, and some of them are very large.
It's only required for yui-compressor, and we don't precompile assets in CI.
tom93
force-pushed
the
gh-actions-skip-assets-gems
branch
from
1e9a306 to
8e65364
Compare
bagedevimo
approved these changes
Jan 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They are not required for running the tests, and some of them are very large.
This also allows us to then skip installing the JRE in CI.
Stacked on #250,
#251.