Use correct group name for isolate/isolock#236
Merged
Conversation
Currently, this configuration variable doesn't *cause* the app to run as that username. We just ask for it so that we can set the correct ownership on some files.
Previously the scripts assumed that the group name is the same as the username, but that's not necessarily the case.
Previously the scripts assumed that the group name is the same as the username, but that's not necessarily the case.
It only needs to be setuid, like isolate.
tom93
changed the title
Holmes98
approved these changes
Jan 1, 2024
tom93
added a commit
that referenced
this pull request
Jan 1, 2024
Currently, this configuration variable doesn't *cause* the app to run as that username. We just ask for it so that we can set the correct ownership on some files.
tom93
added a commit
that referenced
this pull request
Jan 1, 2024
Previously the scripts assumed that the group name is the same as the username, but that's not necessarily the case.
tom93
added a commit
that referenced
this pull request
Jan 1, 2024
Previously the scripts assumed that the group name is the same as the username, but that's not necessarily the case.
Contributor
Author
|
Deployed new permissions of isolock manually. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the scripts assumed that the group name is the same as the username, but that's not necessarily the case.
This came up in #223.
Merge using "rebase".