Fix depth_uint8_decoding calculation for output#198
Open
kleinicke wants to merge 1 commit intoNVlabs:masterfrom
Open
Fix depth_uint8_decoding calculation for output#198kleinicke wants to merge 1 commit intoNVlabs:masterfrom
kleinicke wants to merge 1 commit intoNVlabs:masterfrom
Conversation
uint8 images were incorrectly converted by multiplying by 255 and not shifting correctly by 8 bit by multiplying by 256. This might cause some serious issues, might have even harmed the training of the network. When the dataset for foundation stereo was computed, was this formula used to save the images as 24bit? Or does this issue only occur in the training process? As long as it's consistent between dataset creation and training, this issue is fine for this network. But it should be marked for everyone else trying to train with the dataset, that this formula was used. The previous formula basically interprets 00000000 00000001 00000000 (1*255) 00000000 00000000 10000000 (255) both as 255.
Author
|
Ok, I took a look at the dataset. It's skipping the R=255 and G=255 values. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uint8 images were incorrectly converted by multiplying by 255 and not shifting correctly by 8 bit by multiplying by 256. This might cause some serious issues, might have even harmed the training of the network.
When the dataset for foundation stereo was computed, was this formula used to save the images as 24bit? Or does this issue only occur in the training process? As long as it's consistent between dataset creation and training, this issue is fine for this network. But it should be marked for everyone else trying to train with the dataset, that this formula was used. The previous formula basically interprets
00000000 00000001 00000000 (1*255)
00000000 00000000 10000000 (255)
both as 255.
So in the context of disparities scaled with a factor of 1000, this can mean that a disparity of 300 is saved as 298.
Before merging this change, the implications should be shortly discussed.