includes warping that works in 2d setting #134
Open
svsambandam wants to merge 8 commits intoNVIDIAGameWorks:mainfrom
Open
includes warping that works in 2d setting #134svsambandam wants to merge 8 commits intoNVIDIAGameWorks:mainfrom
svsambandam wants to merge 8 commits intoNVIDIAGameWorks:mainfrom
Conversation
Author
|
yay! it also includes hashnerf-pytorch :) |
Collaborator
|
Hi @svsambandam , thanks a lot for sharing this one! :) From quickly browsing through we would need:
|
Author
|
Hello!
Apologies, that was an accidental commit! I was unsure how to undo it! It's
still very much a work in progress haha. Sorry for the inconvenience!
Best,
Sneha
…On Thu, Mar 23, 2023 at 11:40 AM Or Perel ***@***.***> wrote:
Hi @svsambandam <https://github.com/svsambandam> , thanks a lot for
sharing this one! :)
Is this still work in progress?
From quickly browsing through we would need:
1. To clean up some of the redundant code (i.e. _raymarch_2d, debug
prints, etc)
2. A little example of how to run + expected output
—
Reply to this email directly, view it on GitHub
<#134 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMPJFMC3NCYA2KMOZXBB2SDW5SKIRANCNFSM6AAAAAAWEP3QKY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Collaborator
|
No worries! We're squashing everything before we merge it anyway. Feel free to post as many commits needed, just let me know when this is ready to review & push |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.