Skip to content

Conversation

@carankt
Copy link

@carankt carankt commented Dec 16, 2020

Hey,
I have made the following changes, which helped me work better with the repository. Hoping it would do the same for others.

  • Removed the tensorflow1.x dependency
  • Created a .yaml config file in place of the hparams.py file
  • implemented the changes for training and inference code

Best,
KT

@carankt carankt changed the title Remove tensorflow1.x version dependency Remove tensorflow1.x dependency Dec 16, 2020
@lgtm-com
Copy link

lgtm-com bot commented Dec 16, 2020

This pull request introduces 2 alerts when merging 9f285fe into 185cd24 - view on LGTM.com

new alerts:

  • 1 for Missing call to __init__ during object initialization
  • 1 for First argument to super() is not enclosing class

tensorflow==1.15.2
numpy==1.13.3
inflect==0.2.5
librosa==0.6.0
Copy link

@sabard sabard Dec 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pyyaml package is also required here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants