pin black and isort versions #1007
Merged
eordentlich merged 2 commits intoNVIDIA:release/25.12from Jan 20, 2026
Merged
Conversation
…re released Signed-off-by: Erik Ordentlich <eordentlich@gmail.com>
Collaborator
Author
|
fixes #1006 |
Collaborator
Author
|
build |
Contributor
Greptile SummaryPinned
These formatting tools are used in Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Dev as Developer
participant CI as CI System
participant Pip as pip install
participant Lint as lint_python.py
participant Black as black
participant Isort as isort
Dev->>CI: Push code / PR
CI->>Pip: Install requirements_dev.txt
Pip->>Pip: Install black==25.12.0
Pip->>Pip: Install isort==7.0.0
CI->>Lint: Run formatting checks
Lint->>Isort: isort --check --profile=black
Isort-->>Lint: Check result
Lint->>Black: black --check
Black-->>Lint: Check result
alt Formatting passes
Lint-->>CI: Success
CI-->>Dev: CI passes
else Formatting fails
Lint-->>CI: Failure with fix commands
CI-->>Dev: CI fails - run formatters
end
|
pxLi
approved these changes
Jan 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #1006
to avoid nightly ci failures when new versions released.
We will need to update manually and reformat code as warranted.