Migrate pre-merge CI image to the new artifactory#1004
Merged
pxLi merged 1 commit intoNVIDIA:mainfrom Jan 9, 2026
Merged
Conversation
Signed-off-by: Peixin Li <pxLi@nyu.edu>
Contributor
There was a problem hiding this comment.
Greptile Overview
Greptile Summary
Updates the pre-merge CI pipeline to use the new artifactory V2 instance by migrating all Docker image references from common.ARTIFACTORY_NAME to common.ARTIFACTORY_NAME_V2 and updating credentials from urm_creds to urm_creds_v2. Removes the unused ART_URL environment variable that was previously defined but never referenced in the pipeline.
Confidence Score: 5/5
- Safe to merge - straightforward configuration migration with consistent updates across all references
- This is a clean infrastructure configuration change that consistently updates all artifactory references. The migration follows a clear pattern: updating image URLs, credentials, and environment variables to use the V2 instance. The ARTIFACTORY_NAME environment variable correctly propagates to all downstream uses (docker login, push, logout, and cleanup). The removal of ART_URL is correct as it was defined but never used in the pipeline.
- No files require special attention
Important Files Changed
File Analysis
| Filename | Score | Overview |
|---|---|---|
| ci/Jenkinsfile.premerge | 5/5 | Migrates Docker image references and credentials from old artifactory to new V2 instance; removes unused ART_URL variable |
Sequence Diagram
sequenceDiagram
participant Pipeline as Jenkins Pipeline
participant OldArt as Old Artifactory
participant NewArt as New Artifactory V2
Note over Pipeline,NewArt: Before: Used old artifactory
Pipeline->>OldArt: "Pull Docker images"
Pipeline->>OldArt: "Push temporary images"
Note over Pipeline,NewArt: After: Migrated to V2
Pipeline->>NewArt: "Pull Docker images (V2)"
Pipeline->>NewArt: "Push temporary images (V2)"
Pipeline->>NewArt: "Authenticate with urm_creds_v2"
Member
Author
|
build |
YanxuanLiu
approved these changes
Jan 9, 2026
NvTimLiu
approved these changes
Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ART_URL.NOTE: Nightly CI will be covered internally