Skip to content

Migrate pre-merge CI image to the new artifactory#1004

Merged
pxLi merged 1 commit intoNVIDIA:mainfrom
pxLi:pre-merge-v2-image
Jan 9, 2026
Merged

Migrate pre-merge CI image to the new artifactory#1004
pxLi merged 1 commit intoNVIDIA:mainfrom
pxLi:pre-merge-v2-image

Conversation

@pxLi
Copy link
Member

@pxLi pxLi commented Jan 9, 2026

  1. Migrate pre-merge Docker image usage to the new artifactory instance in pre-merge.
  2. Removed also non-usage var ART_URL.

NOTE: Nightly CI will be covered internally

Signed-off-by: Peixin Li <pxLi@nyu.edu>
@pxLi pxLi self-assigned this Jan 9, 2026
@pxLi pxLi added the cicd label Jan 9, 2026
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Overview

Greptile Summary

Updates the pre-merge CI pipeline to use the new artifactory V2 instance by migrating all Docker image references from common.ARTIFACTORY_NAME to common.ARTIFACTORY_NAME_V2 and updating credentials from urm_creds to urm_creds_v2. Removes the unused ART_URL environment variable that was previously defined but never referenced in the pipeline.

Confidence Score: 5/5

  • Safe to merge - straightforward configuration migration with consistent updates across all references
  • This is a clean infrastructure configuration change that consistently updates all artifactory references. The migration follows a clear pattern: updating image URLs, credentials, and environment variables to use the V2 instance. The ARTIFACTORY_NAME environment variable correctly propagates to all downstream uses (docker login, push, logout, and cleanup). The removal of ART_URL is correct as it was defined but never used in the pipeline.
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
ci/Jenkinsfile.premerge 5/5 Migrates Docker image references and credentials from old artifactory to new V2 instance; removes unused ART_URL variable

Sequence Diagram

sequenceDiagram
    participant Pipeline as Jenkins Pipeline
    participant OldArt as Old Artifactory
    participant NewArt as New Artifactory V2
    
    Note over Pipeline,NewArt: Before: Used old artifactory
    Pipeline->>OldArt: "Pull Docker images"
    Pipeline->>OldArt: "Push temporary images"
    
    Note over Pipeline,NewArt: After: Migrated to V2
    Pipeline->>NewArt: "Pull Docker images (V2)"
    Pipeline->>NewArt: "Push temporary images (V2)"
    Pipeline->>NewArt: "Authenticate with urm_creds_v2"
Loading

@pxLi
Copy link
Member Author

pxLi commented Jan 9, 2026

build

@pxLi pxLi merged commit c585ab4 into NVIDIA:main Jan 9, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants