Replace cudf::detail::get_value() with cudf::get_element()#4358
Open
davidwendt wants to merge 4 commits intoNVIDIA:mainfrom
Open
Replace cudf::detail::get_value() with cudf::get_element()#4358davidwendt wants to merge 4 commits intoNVIDIA:mainfrom
davidwendt wants to merge 4 commits intoNVIDIA:mainfrom
Conversation
Signed-off-by: David Wendt <dwendt@nvidia.com>
Contributor
Greptile SummaryThis PR replaces two calls to the libcudf internal API Key changes:
Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Caller
participant parse_uri
participant cudf_get_element as cudf::get_element()
participant scalar as numeric_scalar<int32_t>
participant Host
Caller->>parse_uri: parse_uri(input, chunk, ..., stream, mr)
parse_uri->>parse_uri: build offsets_column (INT32, stream)
parse_uri->>parse_uri: exclusive_scan offsets (stream)
parse_uri->>cudf_get_element: get_element(offsets_view, offset_count-1, stream)
Note over cudf_get_element: copies last offset element<br/>to device scalar on `stream`
cudf_get_element-->>parse_uri: unique_ptr<scalar>
parse_uri->>scalar: static_cast<numeric_scalar<int32_t>>.value(stream)
Note over scalar: syncs `stream`, copies<br/>value to host
scalar-->>parse_uri: out_chars_bytes (host int32_t)
parse_uri->>parse_uri: allocate d_out_chars(out_chars_bytes, stream, mr)
parse_uri-->>Caller: strings column
Last reviewed commit: b5c0c95 |
Signed-off-by: David Wendt <dwendt@nvidia.com>
…s-jni into get-element-value Signed-off-by: David Wendt <dwendt@nvidia.com>
Collaborator
|
Build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces calls to libcudf internal
cudf::detail::get_value()with publiccudf::get_element().