always append "-force" for "update" data generation#222
always append "-force" for "update" data generation#222wjxiz1992 wants to merge 2 commits intoNVIDIA:devfrom
Conversation
Signed-off-by: Allen Xu <allxu@nvidia.com>
Signed-off-by: Allen Xu <allxu@nvidia.com>
|
Thanks @wjxiz1992 for having a look at this issue. Should we consider something similar to the solution for hdfs for local as well? Such as skipping generating the delete data once the first file is generated. I'm not sure whether it's a good idea to always assume the |
I get your concern, no worry, so far the duplicated "delete_n" and "invetory_delete_n" dat files are the only buggy part I found in native TPC-DS tool. When using All other data files are like this. so overwrite flag won't cause problem for them. we do Ultimately, yes, we can do similar things as HDFS, but this need like 1. create child folder for each child, 2. move data files from each child folder to the final folder etc. |
jihoonson
left a comment
There was a problem hiding this comment.
@wjxiz1992 and I discussed offline. I don't think this is a good idea given my concern in #222 (comment).
|
let me update this with Jihoon's suggestion. |
|
close this. I created a new one with the suggestion from @jihoonson : #252 |
close #221 .
Use the solution described in the issue. Verified locally with the original failing command line.