Skip to content

Set real uid to effective uid. #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iandall wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Set real uid to effective uid. #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions modprobe-utils/nvidia-modprobe-utils.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,7 @@ static int modprobe_helper(const int print_errors, const char *module_name,
{
char modprobe_path[NV_PROC_MODPROBE_PATH_MAX];
int status = 1;
int euid;
struct stat file_status;
pid_t pid;
const char * const argv[] = { "modprobe", module_name, NULL };
Expand Down Expand Up @@ -217,11 +218,15 @@ static int modprobe_helper(const int print_errors, const char *module_name,

/* Only attempt to load the kernel module if root. */

if (geteuid() != 0)
if ((euid = geteuid()) != 0)
{
return 0;
fprintf(stderr, "euid (%d) not root\n", euid);
return 0;
}

/* Modprobe might call shell scripts and shells revert to real uid */
setuid(euid); /* Set ruid = euid */

/*
* Before attempting to load the module, look for any NVIDIA PCI devices.
* If none exist, exit instead of attempting the modprobe, because doing so
Expand Down Expand Up @@ -300,7 +305,8 @@ static int modprobe_helper(const int print_errors, const char *module_name,

/* Fork and exec modprobe from the child process. */

file_actions = silence_process_actions();
/* file_actions = silence_process_actions(); */
file_actions = NULL; /* Warnings, if they occur, are helpful! */

/*
* POSIX specifies that the argv and envp arguments are arrays of non-const
Expand Down