Skip to content

Conversation

@elezar
Copy link
Member

@elezar elezar commented Jan 21, 2026

This change adds support for Docker Swarm to the NVIDIA Container Runtime. This was removed when the default runtime mode was changed from legacy to jit-cdi.

Fixes #1599

@coveralls
Copy link

coveralls commented Jan 21, 2026

Pull Request Test Coverage Report for Build 21245439182

Details

  • 16 of 17 (94.12%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 36.84%

Changes Missing Coverage Covered Lines Changed/Added Lines %
cmd/nvidia-container-runtime-hook/container_config.go 0 1 0.0%
Totals Coverage Status
Change from base Build 21183749927: 0.0%
Covered Lines: 5257
Relevant Lines: 14270

💛 - Coveralls

Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
@elezar elezar force-pushed the fix-docker-swarm-in-nvidia-runtime branch from a233338 to 6a26342 Compare January 22, 2026 09:25
@elezar elezar added this to the v1.19.0 milestone Jan 22, 2026
This change adds support for Docker Swarm to the NVIDIA
Container Runtime. This was removed when the default runtime
mode was changed from legacy to jit-cdi.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
@elezar elezar requested a review from jgehrcke January 22, 2026 10:09
@elezar elezar added the bug Issue/PR to expose/discuss/fix a bug label Jan 22, 2026
@elezar
Copy link
Member Author

elezar commented Jan 22, 2026

/cherry-pick release-1.18

@elezar elezar modified the milestones: v1.19.0, next-patch Jan 22, 2026
@elezar elezar force-pushed the fix-docker-swarm-in-nvidia-runtime branch from 6a26342 to a290bcf Compare January 22, 2026 10:43
@elezar elezar modified the milestones: next-patch, v1.19.0 Jan 23, 2026
@elezar elezar merged commit bb2bb5c into NVIDIA:main Jan 23, 2026
16 checks passed
@elezar elezar deleted the fix-docker-swarm-in-nvidia-runtime branch January 23, 2026 15:23
@github-actions
Copy link

🤖 Backport PR created for release-1.18: #1608

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issue/PR to expose/discuss/fix a bug cherry-pick/release-1.18

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NVIDIA Container Runtime ignores Docker Swarm generic GPU resource assignments

3 participants