fix: Include /dev/nvidia2 in container requesting iGPU if required #1561
+576
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 21291215829Details
💛 - Coveralls |
elezar
changed the title
Closed
ArangoGutierrez
approved these changes
Jan 23, 2026
Collaborator
ArangoGutierrez
left a comment
ArangoGutierrez
left a comment
There was a problem hiding this comment.
Approved with non-blocking NIT's
pkg/nvcdi/lib-csv.go
Outdated
| noFilterDeviceNodes bool | ||
| index int | ||
| uuid string | ||
| mode string |
Collaborator
There was a problem hiding this comment.
Should we consider
type gpuMode string
const (
gpuModeDGPU gpuMode = "dgpu"
gpuModeIGPU gpuMode = "igpu"
)
Comment on lines
133
to
134
| for t, p := range p.MountSpecPathsByType() { | ||
| f[t] = &matcherAsFilter{pathPatterns(p)} |
Collaborator
There was a problem hiding this comment.
readability NIT
Suggested change
| for t, p := range p.MountSpecPathsByType() { | |
| f[t] = &matcherAsFilter{pathPatterns(p)} | |
| for t, paths := range p.MountSpecPathsByType() { | |
| f[t] = &matcherAsFilter{pathPatterns(paths)} |
Signed-off-by: Evan Lezar <elezar@nvidia.com>
ArangoGutierrez
approved these changes
Jan 23, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Tegra-based systems where both an iGPU (e.g. Thor) and a dGPU are present, the rendering devices for the iGPU are associated with
/dev/nvidia2. This means that this device node should be included if present.Depends on #1556