-
Notifications
You must be signed in to change notification settings - Fork 55
CUDA: add closure tests\n\nAdds kernel-based tests for device-side cl… #735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…osure capture: constants, scalars, kernel factories, and read-only captures. Skips under cudasim. NumPy is used as the reference. Scope is intentionally limited to safe, well-defined CUDA closure semantics.
Greptile SummaryAdds comprehensive CUDA closure capture tests covering constants, scalars, boolean flags, kernel factories, and multiple constant capture scenarios. All previously identified critical issues (missing SPDX header, weak test assertions, undefined kernel variable, and missing kernel launch) have been resolved.
Confidence Score: 5/5
Important Files Changed
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, 1 comment
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, 1 comment
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, 1 comment
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, 1 comment
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
This PR adds kernel-based tests for device-side closure capture in Numba-CUDA:
Constants and scalar values
Kernel factories with closure capture
Read-only captures
Tests are skipped under cudasim due to divergent semantics, and NumPy is used as the reference oracle. The scope is intentionally limited to safe, well-defined CUDA closure semantics (no mutable captures, late binding, or nested closures).
This continues the systematic porting of CPU-side tests to CUDA, directly contributing to issue #515.