CUDA: Add device-side tests for Python builtins (abs, min, max, bool)… #729

CodersAcademy006 · 2026-01-20T10:33:19Z

This PR adds kernel-based tests for device-side execution of common Python builtins (abs, min, max, bool) on supported dtypes. The tests are:

Skipped under cudasim to avoid simulator/Python semantic mismatches
Compared against NumPy as the ground truth
Focused on CUDA-safe, well-defined builtins only
This improves CUDA test parity and references issue Incomplete Test Coverage in Numba-CUDA #515.

…NVIDIA#515) Adds kernel-based tests for device-side execution of common Python builtins (abs, min, max, bool) on supported dtypes. Tests are skipped under cudasim and use NumPy as the ground truth. This improves CUDA test parity and references issue NVIDIA#515.

copy-pr-bot · 2026-01-20T10:33:23Z

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

greptile-apps · 2026-01-20T10:36:27Z

Greptile Summary

Adds device-side CUDA tests for Python builtins (abs, min, max, bool) to improve test parity with Numba (issue #515).

Tests correctly skip execution under cudasim to avoid semantic mismatches
Proper edge case coverage including NaN propagation in floating-point operations
Helper method _launch_1d validates all array sizes match before kernel launch
Tests compare against NumPy as ground truth using appropriate assertion methods

All previously identified concerns are style-related (extra blank lines, bounds check consistency patterns) and have been documented in prior review threads. The implementation is functionally correct and adds valuable test coverage.

Confidence Score: 4/5

Safe to merge with minor style improvements already noted in previous review
The PR adds comprehensive test coverage for CUDA builtins (abs, min, max, bool) with proper edge case handling including NaN values. All previously identified issues are style-related (extra blank lines, bounds check patterns) and don't affect correctness. The _launch_1d helper validates array sizes before kernel launch, ensuring safe execution.
No files require special attention - all concerns are minor style issues

Important Files Changed

Filename	Overview
numba_cuda/numba/cuda/tests/test_builtins.py	New test file for CUDA builtin functions - all previously identified style issues have been addressed, tests are well-structured with proper NaN handling

greptile-apps

_{1 file reviewed, 3 comments}

_{Edit Code Review Agent Settings | Greptile}

numba_cuda/numba/cuda/tests/test_builtins.py

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

greptile-apps

_{1 file reviewed, 2 comments}

_{Edit Code Review Agent Settings | Greptile}

numba_cuda/numba/cuda/tests/test_builtins.py

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

greptile-apps

_{1 file reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

numba_cuda/numba/cuda/tests/test_builtins.py

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

- Remove defensive bounds checking from kernels (trust Python validation) - Add explicit size validation in _launch_1d helper (fail loud) - Replace CPU zero allocation with direct device_array_like/device_array - Remove redundant cuda.synchronize() (copy_to_host implicitly syncs) - Add test_min_float_edge_cases for NaN and signed zero handling - Improve test efficiency and compiler correctness verification

…uplicate test_abs_int definition\n- Use only if i < out.size: in min_kernel and max_kernel (Python enforces size)

greptile-apps

_{1 file reviewed, 4 comments}

_{Edit Code Review Agent Settings | Greptile}

numba_cuda/numba/cuda/tests/test_builtins.py

greptile-apps

_{1 file reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

numba_cuda/numba/cuda/tests/test_builtins.py

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

greptile-apps bot reviewed Jan 20, 2026

View reviewed changes

numba_cuda/numba/cuda/tests/test_builtins.py Show resolved Hide resolved

numba_cuda/numba/cuda/tests/test_builtins.py Outdated Show resolved Hide resolved

numba_cuda/numba/cuda/tests/test_builtins.py Outdated Show resolved Hide resolved

CodersAcademy006 and others added 2 commits January 21, 2026 11:10

Update numba_cuda/numba/cuda/tests/test_builtins.py

b181d29

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

Update numba_cuda/numba/cuda/tests/test_builtins.py

16aed6f

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

greptile-apps bot reviewed Jan 21, 2026

View reviewed changes

numba_cuda/numba/cuda/tests/test_builtins.py Show resolved Hide resolved

numba_cuda/numba/cuda/tests/test_builtins.py Show resolved Hide resolved

CodersAcademy006 and others added 3 commits January 21, 2026 11:43

Update numba_cuda/numba/cuda/tests/test_builtins.py

22f73d4

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

Update numba_cuda/numba/cuda/tests/test_builtins.py

257ce6a

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

Update numba_cuda/numba/cuda/tests/test_builtins.py

73f8512

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

greptile-apps bot reviewed Jan 21, 2026

View reviewed changes

numba_cuda/numba/cuda/tests/test_builtins.py Outdated Show resolved Hide resolved

CodersAcademy006 and others added 3 commits January 21, 2026 11:45

Update numba_cuda/numba/cuda/tests/test_builtins.py

6481fe2

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

Fix duplicate test_abs_int and simplify min/max kernels\n\n- Remove d…

3f7e60e

…uplicate test_abs_int definition\n- Use only if i < out.size: in min_kernel and max_kernel (Python enforces size)

greptile-apps bot reviewed Jan 21, 2026

View reviewed changes

style: Remove extra blank lines between test methods for consistency

8ea22b2

greptile-apps bot reviewed Jan 21, 2026

View reviewed changes

numba_cuda/numba/cuda/tests/test_builtins.py Outdated Show resolved Hide resolved

Update numba_cuda/numba/cuda/tests/test_builtins.py

0366753

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

CUDA: Add device-side tests for Python builtins (abs, min, max, bool)… #729

Are you sure you want to change the base?

CUDA: Add device-side tests for Python builtins (abs, min, max, bool)… #729

Uh oh!

Conversation

CodersAcademy006 commented Jan 20, 2026

Uh oh!

copy-pr-bot bot commented Jan 20, 2026

Uh oh!

greptile-apps bot commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 4/5

Important Files Changed

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

greptile-apps bot commented Jan 20, 2026 •

edited

Loading