-
Notifications
You must be signed in to change notification settings - Fork 55
Cuda casting tests #728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Cuda casting tests #728
Conversation
…IDIA#515) This adds kernel-based tests for device-side casting between common numeric and boolean dtypes, mirroring a subset of CPU test_casting. Tests are skipped under cudasim. References: NVIDIA#515.
Greptile SummaryThis PR adds a new comprehensive test suite for CUDA device-side casting operations, addressing issue #515 to improve test coverage for Numba-CUDA. The implementation validates casting between numeric types (int32, int64, float32, float64) and boolean conversions, with special attention to CUDA's C-style truncation semantics for float-to-int conversions. The test suite is well-structured with:
Confidence Score: 5/5
Important Files Changed
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, 1 comment
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, 1 comment
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, 2 comments
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, 3 comments
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, 1 comment
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, 1 comment
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
- Use cuda.device_array() instead of zeros+to_device for efficiency - Remove duplicate cuda.synchronize() calls (copy_to_host is already sync) - Eliminate unnecessary Host-to-Device memory transfer
This PR adds kernel-based tests for device-side casting between common numeric and boolean dtypes, mirroring a subset of the CPU-side
test_castinglogic. The tests validate CUDA device semantics for: