Skip to content

Conversation

@tariq1890
Copy link
Contributor

This change allows the namespace to be retrieved by the toolkit container at runtime when instantiating the NRI plugin server

@tariq1890 tariq1890 marked this pull request as ready for review January 22, 2026 05:40
@coveralls
Copy link

coveralls commented Jan 22, 2026

Coverage Status

coverage: 25.211%. remained the same
when pulling 68262bf on toolkit-namespace-env
into 23e5272 on main.

… container

Signed-off-by: Tariq Ibrahim <tibrahim@nvidia.com>
@tariq1890 tariq1890 force-pushed the toolkit-namespace-env branch from adf85d3 to 68262bf Compare January 22, 2026 20:51
Copy link
Member

@karthikvetrivel karthikvetrivel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@tariq1890
Copy link
Contributor Author

Thanks for the review @karthikvetrivel ! This PR should be good to merge now that NVIDIA/nvidia-container-toolkit#1601 has been merged

@tariq1890 tariq1890 merged commit 57fd3fd into main Jan 23, 2026
17 checks passed
@tariq1890 tariq1890 deleted the toolkit-namespace-env branch January 23, 2026 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants