-
Notifications
You must be signed in to change notification settings - Fork 43
AI Dynamo updates #814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
karya0
wants to merge
21
commits into
NVIDIA:main
Choose a base branch
from
karya0:dynamo-genaiperf
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
AI Dynamo updates #814
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
a3792f9
AI-Dynamo updates.
karya0 b130877
Removed aiperf, lmbench, and kvstorage.
karya0 e8b1d73
Fix tests after removing aiperf, lmbench, kvstorage, and calc_percent…
karya0 a6b0cbb
Fix ruff lint errors in ai_dynamo and kubernetes_system.
karya0 fdc040c
Fix ruff format and test_container_mounts CI failures.
karya0 4127211
Address CodeRabbit review feedback.
karya0 e0b464b
Simplify AI Dynamo worker args and move defaults into code
karya0 663ddb0
Fix CI: suppress ruff B010 for setattr and update sbatch ref data
karya0 3b5cf7f
Fixed set_backend_defaults.
karya0 4a4d226
Misc changes.
karya0 3e74901
Make hf_home_path validation best-effort for remote filesystems
karya0 12454a6
Skip HF model download when hf_home_path is not locally accessible
karya0 0cd6d4b
Fix CI: lint errors and test failures from hf_home_path mount
karya0 98d73c3
Model name.
karya0 a6abf3a
Add --hf-home arg to ai-dynamo sbatch reference data
karya0 220c575
Fix copyright year and TOML formatting
karya0 c2b6201
Misc fixes.
karya0 aece52c
Default TP/PP/DP set to 1.
karya0 19246d3
Default DP to None.
karya0 5af16b8
Fixed ref data.
karya0 4bece02
Genai_perf fixes.
karya0 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,107 @@ | ||
| # SPDX-FileCopyrightText: NVIDIA CORPORATION & AFFILIATES | ||
| # Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| name = "sglang-Qwen3-0.6B" | ||
| description = "sglang backend with Qwen3-0.6B model" | ||
| test_template_name = "AIDynamo" | ||
|
|
||
| [cmd_args] | ||
| docker_image_url = "nvcr.io/nvidia/ai-dynamo/sglang-runtime:0.9.0" | ||
| num_nodes = 2 | ||
| workloads = "genai_perf.sh" | ||
|
|
||
| [cmd_args.dynamo] | ||
| backend = "sglang" | ||
| model = "Qwen/Qwen3-0.6B" | ||
| endpoint = "v1/chat/completions" | ||
|
|
||
| [cmd_args.dynamo.prefill_worker] | ||
| num-nodes = 1 | ||
| cmd = 'python3 -m dynamo.sglang' | ||
| extra-args = "--trust-remote-code --skip-tokenizer-init --enable-metrics" | ||
| worker-initialized-regex = 'register._register_llm_with_runtime_config:.Successfully.registered.LLM.with.runtime.config' | ||
| multiple-workers-per-node = "false" | ||
|
|
||
| [cmd_args.dynamo.prefill_worker.args] | ||
| page-size = 16 | ||
| tensor-parallel-size = 1 | ||
| pipeline-parallel-size = 1 | ||
| disaggregation-mode = "prefill" | ||
| disaggregation-bootstrap-port = 12345 | ||
| host = "0.0.0.0" | ||
| port = 40000 | ||
| disaggregation-transfer-backend = "nixl" | ||
|
|
||
| [cmd_args.dynamo.decode_worker] | ||
| num-nodes = 1 | ||
| cmd = 'python3 -m dynamo.sglang' | ||
| extra-args = "--trust-remote-code --skip-tokenizer-init --enable-metrics" | ||
| worker-initialized-regex = 'register._register_llm_with_runtime_config:.Successfully.registered.LLM.with.runtime.config' | ||
| multiple-workers-per-node = "false" | ||
|
|
||
| [cmd_args.dynamo.decode_worker.args] | ||
| page-size = 16 | ||
| tensor-parallel-size = 1 | ||
| pipeline-parallel-size = 1 | ||
| disaggregation-mode = "decode" | ||
| disaggregation-bootstrap-port = 12345 | ||
| host = "0.0.0.0" | ||
| disaggregation-transfer-backend = "nixl" | ||
|
|
||
| [cmd_args.lmcache] | ||
| controller_cmd = "lmcache_controller --host localhost --port 9000 --monitor-port 9001" | ||
|
|
||
| [cmd_args.lmcache.args] | ||
| chunk_size = 256 | ||
| local_cpu = false | ||
| nixl_buffer_size = 10737418240 | ||
| nixl_buffer_device = "cuda" | ||
| extra_config_enable_nixl_storage = true | ||
| extra_config_nixl_backend = "GDS_MT" | ||
| extra_config_nixl_file_pool_size = 64 | ||
|
|
||
| enable_controller = true | ||
| lmcache_instance_id = "lmcache_default_instance" | ||
| controller_url = "localhost:9001" | ||
| lmcache_worker_port = 8788 | ||
| distributed_url = "localhost:8789" | ||
|
|
||
| [cmd_args.genai_perf] | ||
| cmd = "genai-perf profile" | ||
| extra-args = "--streaming --verbose -- -v --async" | ||
|
|
||
| [cmd_args.genai_perf.args] | ||
| endpoint-type = "chat" | ||
| extra-inputs = 'min_tokens:10' | ||
| output-tokens-mean = 500 | ||
| output-tokens-stddev = 0 | ||
| random-seed = 123 | ||
| request-count = 50 | ||
| synthetic-input-tokens-mean = 300 | ||
| synthetic-input-tokens-stddev = 0 | ||
| warmup-request-count = 5 | ||
| concurrency = 2 | ||
|
|
||
| [extra_env_vars] | ||
| UCX_LOG_LEVEL = "warn" | ||
| HF_HUB_OFFLINE = "1" | ||
| TRANSFORMERS_OFFLINE = "1" | ||
| HF_DATASETS_OFFLINE = "1" | ||
| DYNAMO_NODELIST = "$(scontrol show hostname $SLURM_JOB_NODELIST | tr -s '\\n' ',')" | ||
| UCX_TLS = "all" | ||
| #DYN_LOGGING_JSONL="true" | ||
| #OTEL_EXPORT_ENABLED="1" | ||
| #OTEL_EXPORTER_OTLP_TRACES_ENDPOINT="http://localhost:4317" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
44 changes: 44 additions & 0 deletions
44
conf/experimental/ai_dynamo/test_scenario/sglang_slurm.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| # SPDX-FileCopyrightText: NVIDIA CORPORATION & AFFILIATES | ||
| # Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| name = "dynamo_sglang" | ||
|
|
||
| [[Tests]] | ||
| id = "sglang-Qwen3-0.6B" | ||
| test_name = "sglang-Qwen3-0.6B" | ||
| time_limit = "00:20:00" | ||
|
|
||
| extra_container_mounts = ["/run/udev:/run/udev", "/tmp:/tmp"] | ||
|
|
||
| [Tests.cmd_args] | ||
| num_nodes = 2 # 1 prefill node + 1 decode node | ||
| workloads = "genai_perf.sh" | ||
|
|
||
| [Tests.cmd_args.dynamo] | ||
| model = "Qwen/Qwen3-0.6B" | ||
| node-setup-cmd = "hostname" | ||
|
|
||
| [Tests.cmd_args.dynamo.prefill_worker] | ||
| num-nodes = 1 | ||
|
|
||
| [Tests.cmd_args.dynamo.prefill_worker.args] | ||
| tensor-parallel-size = 1 | ||
|
|
||
| [Tests.cmd_args.dynamo.decode_worker] | ||
| num-nodes = 1 | ||
|
|
||
| [Tests.cmd_args.dynamo.decode_worker.args] | ||
| tensor-parallel-size = 1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
82 changes: 82 additions & 0 deletions
82
conf/experimental/ai_dynamo/test_scenario/vllm_kvbm_slurm.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,82 @@ | ||
| # SPDX-FileCopyrightText: NVIDIA CORPORATION & AFFILIATES | ||
| # Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| name = "dynamo_vllm_kvbm" | ||
|
|
||
| [[Tests]] | ||
| id = "vLLM-Qwen3-0.6B" | ||
| test_name = "vLLM-Qwen3-0.6B" | ||
| time_limit = "20:00:00" | ||
|
|
||
| extra_container_mounts = ["/run/udev:/run/udev", "/tmp:/tmp"] | ||
|
|
||
| [Tests.cmd_args] | ||
| storage_cache_dir = "/mnt/vast" | ||
| num_nodes = 2 # 1 prefill node + 1 decode node | ||
| workloads = "genai_perf.sh" | ||
|
|
||
| [Tests.cmd_args.dynamo] | ||
| model = "Qwen/Qwen3-0.6B" | ||
| node-setup-cmd = "hostname" | ||
|
|
||
| [Tests.cmd_args.dynamo.prefill_worker] | ||
| num-nodes = 1 | ||
|
|
||
| [Tests.cmd_args.dynamo.prefill_worker.args] | ||
| tensor-parallel-size = 2 | ||
| connector = "kvbm nixl" | ||
|
|
||
| [Tests.cmd_args.dynamo.decode_worker] | ||
| num-nodes = 1 | ||
|
|
||
| [Tests.cmd_args.dynamo.decode_worker.args] | ||
| tensor-parallel-size = 2 | ||
| connector = "nixl" | ||
|
|
||
| [Tests.extra_env_vars] | ||
| # Both variants needed for cross-version CUFile compatibility | ||
| CUFILE_LOG_LEVEL = "INFO" | ||
| CUFILE_LOGGING_LEVEL = "INFO" | ||
| PYTHONHASHSEED = "0" | ||
|
|
||
| # Dynamo Flags | ||
| DYN_LOG = "info" | ||
| DYN_SYSTEM_PORT = "8081" # Enable system metrics | ||
|
|
||
| # KVBM Flags | ||
| DYN_KVBM_METRICS = "1" | ||
| DYN_KVBM_METRICS_PORT = "6880" # Default port | ||
|
|
||
| # set a large timeout for allocating the disk | ||
| DYN_KVBM_LEADER_WORKER_INIT_TIMEOUT_SECS = "1200" | ||
| DYN_KVBM_DISABLE_DISK_OFFLOAD_FILTER = "1" # Force KV cache write on first request | ||
|
|
||
| # Use it only on vast. | ||
| #DYN_KVBM_DISK_ZEROFILL_FALLBACK="true" | ||
|
|
||
| # set a relatively small CPU cache, so we can do quick disk onboarding | ||
| DYN_KVBM_CPU_CACHE_GB = "50" | ||
| # set a large disk cache, so we are actually testing the NIXL with onboarding | ||
| #DYN_KVBM_DISK_CACHE_GB="100" | ||
|
|
||
| DYN_KVBM_NIXL_BACKEND_UCX = "True" | ||
| DYN_KVBM_NIXL_BACKEND_GDS = "True" | ||
|
|
||
| # vLLM Flags | ||
| VLLM_SERVER_DEV_MODE = "1" | ||
|
|
||
| DYN_KVBM_LEADER_ZMQ_PUB_PORT = "57001" | ||
| DYN_KVBM_LEADER_ZMQ_ACK_PORT = "57002" | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 Nitpick | 🔵 Trivial
CUFILE_LOG_LEVELandCUFILE_LOGGING_LEVELare both set — clarify intent.These appear to be version-variant names for the same CUFile log-level setting. If both are required for cross-version compatibility, a brief comment explaining this would prevent future readers from treating one as a duplicate and removing it.
♻️ Suggested clarification
+ # Set both variants for CUFile log level — name changed between CUFile versions CUFILE_LOG_LEVEL = "INFO" CUFILE_LOGGING_LEVEL = "INFO"📝 Committable suggestion
🤖 Prompt for AI Agents