Skip to content

Single sbatch + NIXL + ETCD issues #812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
podkidyshev merged 6 commits into from
Feb 20, 2026
Merged

Single sbatch + NIXL + ETCD issues #812

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
eb318e0
gracefully killing etcd
podkidyshev Feb 19, 2026
263ebe4
adjusted tests
podkidyshev Feb 19, 2026
5d378c0
update copyright
podkidyshev Feb 19, 2026
773d523
Merge branch 'main' into ipod/CLOUDAI-18/nixl-etcd-fail
podkidyshev Feb 19, 2026
842449c
redefine kill-wait flow
podkidyshev Feb 19, 2026
256ff50
revert wait solution
podkidyshev Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/cloudai/workloads/common/nixl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# SPDX-FileCopyrightText: NVIDIA CORPORATION & AFFILIATES
# Copyright (c) 2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
# Copyright (c) 2025-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
# SPDX-License-Identifier: Apache-2.0
#
# Licensed under the Apache License, Version 2.0 (the "License");
Expand Down Expand Up @@ -80,7 +80,7 @@ def gen_wait_for_etcd_command(self, timeout: int = 60) -> list[str]:

def gen_kill_and_wait_cmd(self, pid_var: str, timeout: int = 60) -> list[str]:
cmd = [
f"kill -9 ${pid_var}\n",
f"kill -TERM ${pid_var}\n",
"timeout",
str(timeout),
"bash",
Expand Down
4 changes: 2 additions & 2 deletions tests/ref_data/nixl-kvbench.sbatch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ timeout 60 bash -c "until curl -s $NIXL_ETCD_ENDPOINTS/health > /dev/null 2>&1;
srun --export=ALL --mpi=pmix --container-image=url.com/docker:tag --container-mounts=__OUTPUT_DIR__/output:/cloudai_run_results,__OUTPUT_DIR__/install:/cloudai_install,__OUTPUT_DIR__/output --overlap --relative=0 --ntasks-per-node=1 --ntasks=1 -N1 bash -c "source __OUTPUT_DIR__/output/env_vars.sh; path/to/python path/to/kvbench_script.sh profile --backend UCX --etcd_endpoints http://$NIXL_ETCD_ENDPOINTS" &
sleep 15
srun --export=ALL --mpi=pmix --container-image=url.com/docker:tag --container-mounts=__OUTPUT_DIR__/output:/cloudai_run_results,__OUTPUT_DIR__/install:/cloudai_install,__OUTPUT_DIR__/output --overlap --relative=1 --ntasks-per-node=1 --ntasks=1 -N1 bash -c "source __OUTPUT_DIR__/output/env_vars.sh; path/to/python path/to/kvbench_script.sh profile --backend UCX --etcd_endpoints http://$NIXL_ETCD_ENDPOINTS"
kill -9 $etcd_pid
kill -TERM $etcd_pid
timeout 60 bash -c "while kill -0 $etcd_pid 2>/dev/null; do sleep 1; done" || {
echo "Failed to kill ETCD (pid=$etcd_pid) within 60 seconds";
exit 1
}
}
2 changes: 1 addition & 1 deletion tests/ref_data/nixl-perftest.sbatch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ timeout 60 bash -c "until curl -s $NIXL_ETCD_ENDPOINTS/health > /dev/null 2>&1;
exit 1
}
srun --export=ALL --mpi=pmix -N1 --container-image=url.com/docker:tag --container-mounts=__OUTPUT_DIR__/output:/cloudai_run_results,__OUTPUT_DIR__/install:/cloudai_install,__OUTPUT_DIR__/output --overlap bash -c "source __OUTPUT_DIR__/output/env_vars.sh; python /workspace/nixl/benchmark/kvbench/main.py sequential-ct-perftest __OUTPUT_DIR__/output/matrices/metadata.yaml --json-output-path=__OUTPUT_DIR__/output/results.json "
kill -9 $etcd_pid
kill -TERM $etcd_pid
timeout 60 bash -c "while kill -0 $etcd_pid 2>/dev/null; do sleep 1; done" || {
echo "Failed to kill ETCD (pid=$etcd_pid) within 60 seconds";
exit 1
Expand Down
4 changes: 2 additions & 2 deletions tests/ref_data/nixl_bench.sbatch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ timeout 60 bash -c "until curl -s $NIXL_ETCD_ENDPOINTS/health > /dev/null 2>&1;
srun --export=ALL --mpi=pmix --container-image=url.com/docker:2 --container-mounts=__OUTPUT_DIR__/output:/cloudai_run_results,__INSTALL_DIR__:/cloudai_install,__OUTPUT_DIR__/output --overlap --relative=0 --ntasks-per-node=1 --ntasks=1 -N1 bash -c "source __OUTPUT_DIR__/output/env_vars.sh; ./nixlbench --etcd-endpoints http://$NIXL_ETCD_ENDPOINTS --backend UCX" &
sleep 15
srun --export=ALL --mpi=pmix --container-image=url.com/docker:2 --container-mounts=__OUTPUT_DIR__/output:/cloudai_run_results,__INSTALL_DIR__:/cloudai_install,__OUTPUT_DIR__/output --overlap --relative=1 --ntasks-per-node=1 --ntasks=1 -N1 bash -c "source __OUTPUT_DIR__/output/env_vars.sh; ./nixlbench --etcd-endpoints http://$NIXL_ETCD_ENDPOINTS --backend UCX"
kill -9 $etcd_pid
kill -TERM $etcd_pid
timeout 60 bash -c "while kill -0 $etcd_pid 2>/dev/null; do sleep 1; done" || {
echo "Failed to kill ETCD (pid=$etcd_pid) within 60 seconds";
exit 1
}
}
2 changes: 1 addition & 1 deletion tests/workloads/nixl_bench/test_command_gen_strategy_slurm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ def test_gen_kill_and_wait_cmd(nixl_bench_tr: TestRun, slurm_system: SlurmSystem
strategy = NIXLBenchSlurmCommandGenStrategy(slurm_system, nixl_bench_tr)
cmd = strategy.gen_kill_and_wait_cmd("PID", timeout=120)
assert cmd == [
"kill -9 $PID\n",
"kill -TERM $PID\n",
"timeout",
"120",
"bash",
Expand Down