[cuda.compute]: Disable sass checks for float16 merge sort#8053
Open
NaderAlAwar wants to merge 1 commit intoNVIDIA:mainfrom
Open
[cuda.compute]: Disable sass checks for float16 merge sort#8053NaderAlAwar wants to merge 1 commit intoNVIDIA:mainfrom
NaderAlAwar wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
bernhardmgruber
approved these changes
Mar 16, 2026
Contributor
🥳 CI Workflow Results🟩 Finished in 1h 33m: Pass: 100%/56 | Total: 16h 55m | Max: 52m 57sSee results here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#6642 made some kernel changes which lead to
LDLandSTLinstructions in some of the specific cases we test in cuda.compute. This is not a JIT compilation issue since the C++/nvcc path also generates those instructions (a quick benchmark shows that this did not lead to a performance regression). I plan on doing a more thorough investigation of these issues in #7978.Checklist