Fix undefined THREADS_PER_WARP in ln_fwd_kernels.cuh #1955
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The forward layer norm kernel was using
THREADS_PER_WARPwithout declaring it as a local enum, causing build failures after clang-format was applied.Changes
enum { THREADS_PER_WARP = Ktraits::THREADS_PER_WARP };declaration inln_fwd_kernelto match the pattern used inln_bwd_kernelThe constant was referenced at lines 36, 37, and 42 but never brought into local scope from the
Ktraitstemplate parameter.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.