target/arm: Use shared helper for KVM_CAP_ARM_RME detection #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The query-cca-capabilities QMP command was using the hardcoded KVM_CAP_ARM_RME value (244), but on kernel 6.16 the capability number is 243. This caused the command to incorrectly report 'RME is not enabled in KVM' even when RME was available. Extract the kernel version detection logic from rme_guest_init() into a shared kvm_arm_rme_get_cap() helper function and use it in both places to ensure consistent behavior. Fixes: b5ae241 ('target/arm: Handle KVM_CAP_ARM_RME ABI change') Signed-off-by: Ian May <ianm@nvidia.com>
nvmochs
approved these changes
Dec 17, 2025
Collaborator
nvmochs
left a comment
nvmochs
left a comment
There was a problem hiding this comment.
Acked-by: Matthew R. Ochs <mochs@nvidia.com>
NathanChenNVIDIA
approved these changes
Dec 17, 2025
NathanChenNVIDIA
left a comment
NathanChenNVIDIA
left a comment
There was a problem hiding this comment.
Acked-by: Nathan Chen nathanc@nvidia.com
Collaborator
|
Merged, closing MR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The query-cca-capabilities QMP command was using the hardcoded KVM_CAP_ARM_RME value (244), but on kernel 6.16 the capability number is 243. This caused the command to incorrectly report 'RME is not enabled in KVM' even when RME was available.
Extract the kernel version detection logic from rme_guest_init() into a shared kvm_arm_rme_get_cap() helper function and use it in both places to ensure consistent behavior.
Fixes: b5ae241 ('target/arm: Handle KVM_CAP_ARM_RME ABI change')