fix ddp bug when --overlap-grad-reduce and --num-optim > 1#3693
Open
wplf wants to merge 3 commits intoNVIDIA:mainfrom
Open
fix ddp bug when --overlap-grad-reduce and --num-optim > 1#3693wplf wants to merge 3 commits intoNVIDIA:mainfrom
wplf wants to merge 3 commits intoNVIDIA:mainfrom
Conversation
6 tasks
Member
Author
|
Hi @zyeric, Please review this PR and thank you for your contribution again. |
Member
Author
|
/claude review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for zyeric's issue, you can see more details in #3670.
Bug reproduce and fix
Any member of core-adlr and
core-nemowill be able to merge your PR.