Skip to content

Improve error logging when invalid number of tokens is requested. #3680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yobibyte wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −0
Open

Improve error logging when invalid number of tokens is requested. #3680

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions megatron/core/inference/engines/dynamic_engine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -789,10 +789,16 @@ def _add_request(
len(request.prompt_tokens) + request.sampling_params.num_tokens_to_generate
> self.context.max_sequence_length
) or (request.sampling_params.num_tokens_to_generate < 0):
logging.error(
f"Invalid number of tokens to generate. Prompt len: {len(request.prompt_tokens)}, tokens to generate: {request.sampling_params.num_tokens_to_generate}, max seq len: {self.context.max_sequence_length}."
)
request.status = Status.FAILED
request.add_event_error_nontransient(MaxSequenceLengthOverflowError(request_id))

if len(request.prompt_tokens) > self.context.max_tokens and not self.enable_chunked_prefill:
logging.error(
f"Prompt is longer than context.max_tokens. Prompt tokens: {len(request.prompt_tokens)}, context.max_tokens: {self.context.max_tokens}, chunked_prefill: {self.enable_chunked_prefill}"
)
request.status = Status.FAILED
request.add_event_error_nontransient(TokenOverflowError(request_id))

Expand Down
Loading