Skip to content

[MoE] Add a new score function to the router#3673

Draft
yaox12 wants to merge 1 commit intoNVIDIA:mainfrom
yaox12:xiny/add_new_score_func
Draft

[MoE] Add a new score function to the router#3673
yaox12 wants to merge 1 commit intoNVIDIA:mainfrom
yaox12:xiny/add_new_score_func

Conversation

@yaox12
Copy link
Member

@yaox12 yaox12 commented Mar 3, 2026

What does this PR do ?

  1. Add a new score function sqrtsoftplus to the router.
  2. Change a little to how we handle the precision in the router
  • TLDR: In topk_routing_with_score_function, we only convert to BF16 before returning (not in the middle).
  • Basic rules:
    • Logits are converted to fp32 at the beginning for score functions.
    • All the intermediate calculations are in fp32.
    • The final probs are casted to the same dtype as the logits.
    • In compute_routing_scores_for_aux_loss, we always use FP32.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

Signed-off-by: Xin Yao <xiny@nvidia.com>
@copy-pr-bot
Copy link

copy-pr-bot bot commented Mar 3, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@yaox12
Copy link
Member Author

yaox12 commented Mar 3, 2026

/ok to test 37c8610

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants