Save replicated tensors per-TP-rank and load with file locality#3392
Draft
sbak5 wants to merge 1 commit intoNVIDIA:mainfrom
Draft
Save replicated tensors per-TP-rank and load with file locality#3392sbak5 wants to merge 1 commit intoNVIDIA:mainfrom
sbak5 wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
Save path:
- Assign each TP rank a unique checkpoint key for replicated tensors
(.__tp_replica_{tp_rank}) so each rank writes to its own file.
- Set replica_id to (0, 0, dp_replica_id) for these tensors.
Load path:
- Build FQN→source_rank from checkpoint metadata (distcp filenames).
- In distribute_shards_to_ranks, group shards by source file and
assign each group to that rank so each rank reads from its own file
when possible, reducing file opens on distributed filesystems.
- Pass checkpoint_dir into apply_loading_parallelization to enable
file-locality-aware distribution.
Backward compatibility:
- Detect checkpoints saved without TP-replica postfix keys and strip
the postfix from load-side ShardedTensor keys so they match metadata.
Co-authored-by: Antoni-Joan Solergibert <asolergibert@nvidia.com>
Member
|
We are changing our review process and marking all open, unlabeled PRs as draft. This change will go in effect starting once #3659 is merged. Moving forward, all PRs will be required to start as draft PRs. If you wish to get your PR merged, mark your PR as “Ready for review”. Read more about the new process at submit.md. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Save path:
Load path:
Backward compatibility:
What does this PR do ?
Contribution process
flowchart LR A[Pre-checks] --> B[PR Tests] subgraph Code Review/Approval C1[Expert Review] --> C2[Final Review] end B --> C1 C2 --> D[Merge]Pre-checks
Core 0.8)Code review
The following process is enforced via the CODEOWNERS file for changes into
megatron/core. For changes outside ofmegatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.For MRs into `main` branch
Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!
(Step 1): Add PR label
Expert Review(Step 2): Collect the expert reviewers reviews
Expert Reviewlabel when your PR is ready for review.Final Review might get declined if these requirements are not fulfilled.
(Step 3): Final Review
Final Reviewlabel(Optional Step 4): Cherry-pick into release branch
If this PR also needs to be merged into
core_r*release branches, after this PR has been merged, selectCherry-pickto open a new PR into the release branch.For MRs into `dev` branch
The proposed review process for `dev` branch is under active discussion.MRs are mergable after one approval by either
eharper@nvidia.comorzijiey@nvidia.com.Merging your PR
Any member of core-adlr and
core-nemowill be able to merge your PR.