Add retry logic with configurable delays to checkpoint write operations#2746
Draft
apaithankar wants to merge 2 commits intoNVIDIA:mainfrom
Draft
Add retry logic with configurable delays to checkpoint write operations#2746apaithankar wants to merge 2 commits intoNVIDIA:mainfrom
apaithankar wants to merge 2 commits intoNVIDIA:mainfrom
Conversation
sbak5
reviewed
Dec 24, 2025
| # Reset results for each retry attempt | ||
| local_results = [] | ||
|
|
||
| with open_file(file_name, "wb") as stream: |
Contributor
There was a problem hiding this comment.
Instead of trying to write the whole file every attempt, Can you use io.ByteIO in some number of buffers and apply retrying the write and fsync on each buffer?
_write_item calls torch.save which computes CRC32 of the tensor and do write.
So, if we retry the whole steps, then we will do this computation again.
What we want to achieve here is to have resiliency in the filesystem backend.
Add tests for testing ckpt save retry
… write the entire file when writing a single item fails
0d62973 to
4e2a97b
Compare
Member
|
We are changing our review process and marking all open, unlabeled PRs as draft. This change will go in effect starting once #3659 is merged. Moving forward, all PRs will be required to start as draft PRs. If you wish to get your PR merged, mark your PR as “Ready for review”. Read more about the new process at submit.md. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a retry loop to filesystemAsyncWriter for each item that generates an exception.
What does this PR do ?
Implement retry loop in write_preloaded_data() to handle failures during checkpoint saves.
Logging for item write retry attempts and final failures.
Updated unit tests
Contribution process
flowchart LR A[Pre-checks] --> B[PR Tests] subgraph Code Review/Approval C1[Expert Review] --> C2[Final Review] end B --> C1 C2 --> D[Merge]Pre-checks
Core 0.8)Code review
The following process is enforced via the CODEOWNERS file for changes into
megatron/core. For changes outside ofmegatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.For MRs into `main` branch
(Step 1): Add PR label
Expert Review(Step 2): Collect the expert reviewers reviews
Expert Reviewlabel when your PR is ready for review.Final Review might get declined if these requirements are not fulfilled.
(Step 3): Final Review
Final Reviewlabel(Optional Step 4): Cherry-pick into release branch
If this PR also needs to be merged into
core_r*release branches, after this PR has been merged, selectCherry-pickto open a new PR into the release branch.For MRs into `dev` branch
The proposed review process for `dev` branch is under active discussion.MRs are mergable after one approval by either
eharper@nvidia.comorzijiey@nvidia.com.Merging your PR
Any member of core-adlr and
core-nemowill be able to merge your PR.