Skip to content

Fix torch_dist checkpointing ETP replica_id #1770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Skylion007 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fix torch_dist checkpointing ETP replica_id #1770

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion megatron/core/transformer/moe/experts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,7 @@ def sharded_state_dict(self, prefix='', sharded_offsets=(), metadata=None):
local_expert_indices_offset = ep_rank * self.num_local_experts

prepend_axis_num = len(sharded_offsets)
replica_id = (0, 0, dp_rank)
replica_id = (0, tp_rank, dp_rank)

local_ffn_dim_size = (
self.weight2.numel() // self.num_local_experts // self.config.hidden_size
Expand Down