perf(MoE): Use TE quant/dequant for SwiGLU fp8 input store to improve performance and stability#1753
Draft
xiaoxi-wangfj wants to merge 3 commits intoNVIDIA:mainfrom
Draft
perf(MoE): Use TE quant/dequant for SwiGLU fp8 input store to improve performance and stability#1753xiaoxi-wangfj wants to merge 3 commits intoNVIDIA:mainfrom
xiaoxi-wangfj wants to merge 3 commits intoNVIDIA:mainfrom
Conversation
ksivaman
reviewed
Oct 8, 2025
ksivaman
approved these changes
Oct 8, 2025
Member
ksivaman
left a comment
There was a problem hiding this comment.
LGTM, except a small nit to not import internal API as the exact structure of the files might change or move around in TE
… performance and stability Co-authored-by: xiaoxi-wangfj <690912414@qq.com> Co-authored-by: pumpkinsm <123sssmmm@gmail.com> Co-authored-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
ccdbe18 to
cd7f9fe
Compare
Contributor
Author
|
@ksivaman Thanks for the review! I’ve addressed all the comments and updated the PR. Could you please re-review when you get a chance? |
ksivaman
approved these changes
Dec 31, 2025
Member
|
We are changing our review process and marking all open, unlabeled PRs as draft. This change will go in effect starting once #3659 is merged. Moving forward, all PRs will be required to start as draft PRs. If you wish to get your PR merged, mark your PR as “Ready for review”. Read more about the new process at submit.md. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace native .to(fp8) casting in SwiGLU with Transformer Engine quant/dequant interfaces for storing activation inputs in FP8.
Benefits: