Design: [Mirror #1144] [Mirror] Expected Runtime Plugin for Soft Eviction via Requeue Action#1145
Draft
omer-dayan wants to merge 1 commit intomainfrom
Draft
Design: [Mirror #1144] [Mirror] Expected Runtime Plugin for Soft Eviction via Requeue Action#1145omer-dayan wants to merge 1 commit intomainfrom
omer-dayan wants to merge 1 commit intomainfrom
Conversation
…tion via Requeue Action Propagated from shadow PR omer-dayan/KAI-Scheduler#60
Contributor
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Comment |
omer-dayan
commented
Mar 5, 2026
| - Promote `expectedRuntime` and `requeueDelay` to `PodGroup.spec` fields (with annotation backward compatibility shim). | ||
| - Annotations remain supported as overrides for compatibility. | ||
| - Add kubebuilder validation tags for all new spec fields. | ||
| - Finalize naming of annotation keys (remove TBDs). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Propagated from shadow repo
Shadow PR: omer-dayan/KAI-Scheduler#60
Design Document
This PR adds an architectural design document for the feature requested in #59.
Design File:
docs/developer/designs/59-expected-runtime-plugin.mdReview Checklist
Please review the design document for:
Quality Score: 45.0/100
Errors: 3
Warnings: 4
View Full Report
Design Document Validation Report
Status: ❌ FAILED
Quality Score: 45.0/100
Issues Found: 7
❌ Errors (Must Fix)
1. Required section 'Proposal' is missing
Category: completeness
Suggestion: Add a '## Proposal' section to the document
2. Required section 'Design Details' is missing
Category: completeness
Suggestion: Add a '## Design Details' section to the document
3. Required section 'Test Plan' is missing
Category: completeness
Suggestion: Add a '## Test Plan' section to the document
1. Recommended section 'Graduation Criteria' is missing
Category: completeness
Suggestion: Consider adding a '## Graduation Criteria' section
2. API changes detected but no validation tags found
Category: content
Suggestion: Add kubebuilder validation tags (e.g., +kubebuilder:validation:Required)
3. Heading hierarchy jump (level 1 to 3)
Line: 649
Category: formatting
Suggestion: Use incremental heading levels (don't skip levels)
4. Heading hierarchy jump (level 1 to 3)
Line: 690
Category: formatting
Suggestion: Use incremental heading levels (don't skip levels)
Related Issue: #59
Designed by KAI Agent