feat: make RayGrouper work with TopologyConstraints#1125
feat: make RayGrouper work with TopologyConstraints#1125rueian wants to merge 3 commits intoNVIDIA:mainfrom
Conversation
Signed-off-by: Rueian Huang <rueiancsie@gmail.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Signed-off-by: Rueian Huang <rueiancsie@gmail.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4f069567ad
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: Rueian Huang <rueiancsie@gmail.com>
Merging this branch will decrease overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
|
|
||
| ### Required Configuration | ||
|
|
||
| 1. **Queue Annotation**: Add `scheduling.run.ai/queue-name` annotation on the RayJob or RayCluster metadata to specify the scheduling queue |
Description
This PR allows KubeRay users to set topologyConstraints on each subgroup through kai annotations.
Manual E2E Test
Given the following RayCluster and topology
Will result in this PodGroup:
Checklist
Breaking Changes
Additional Notes