fix: typo in kafka broker #430
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
To be honest, I am aware of the problem for quite some time. I kind of ignored it to avoid compatibility problems. I think it should be fixed. @yingcanw Are you fine with us fixing this? |
bashimao
added
fea::refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reviewing the WeChat article, I came across a subtle typographical error within the parameters of
CreateSolverinterface, wherekafka_brokerswas mistakenly referred to askafka_brockers. Considering that this minor oversight could lead to potential confusion or implementation issues, I believe it is imperative to correct this.Additionally, I encountered an inconsistency: in the official Python interface documentation, the
CreateSolverinterface does not mention akafka_brockersparameter. This has led to some confusion, and I am seeking clarification on this matter.