Skip to content

Update Helm chart URLs and chart versions#159

Merged
AjayThorve merged 6 commits intoNVIDIA-AI-Blueprints:developfrom
cdgamarose-nv:cdgamarose/update_release_tags
Mar 18, 2026
Merged

Update Helm chart URLs and chart versions#159
AjayThorve merged 6 commits intoNVIDIA-AI-Blueprints:developfrom
cdgamarose-nv:cdgamarose/update_release_tags

Conversation

@cdgamarose-nv
Copy link
Collaborator

No description provided.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Mar 18, 2026

Greptile Summary

This PR updates both Helm deployment guides to replace the generic helm repo add / helm repo update workflow with a concrete direct-URL install pattern, hardcoding the chart name (aiq2-web) and version (2.0.0) in all command examples. The OCI (oci://nvcr.io/...) references in the FRAG integration section of docs/source/deployment/kubernetes.md are also replaced with the .tgz-based flow. The .secrets.baseline file is updated mechanically to reflect the new line number of a tracked secret and a refreshed timestamp.

Key issues found:

  • The Upgrade sections in both deploy/helm/README.md (line 172) and docs/source/deployment/kubernetes.md (line 289) tell the user to pull a new version's archive, but the helm upgrade command immediately below still references aiq2-web-2.0.0.tgz — the current version. A user copying the command verbatim would not actually upgrade to the new version they pulled.
  • The helm pull command (e.g. deploy/helm/README.md line 74) uses a literal <YOUR_NGC_API_KEY> placeholder while the install command right below it uses $NGC_API_KEY. The inconsistency may confuse users; the note on line 89 clarifies this, but it would be cleaner to use $NGC_API_KEY in the helm pull command as well.

Confidence Score: 4/5

  • Safe to merge after addressing the misleading upgrade command version reference; all other changes are documentation improvements with no functional impact.
  • The changes are documentation-only. The single actionable bug is a version mismatch in the upgrade example command that would cause users following the guide to re-install the same version rather than upgrading — a real usability problem but not a runtime or security issue. All other changes are clear improvements (concrete URLs, consistent flags, improved credential guidance).
  • deploy/helm/README.md line 172 and docs/source/deployment/kubernetes.md line 289 — upgrade command uses the old chart version

Important Files Changed

Filename Overview
deploy/helm/README.md Replaces the generic helm repo add workflow with a direct .tgz URL install pattern, hardcoding chart name and version. One issue: the Upgrade section command still references aiq2-web-2.0.0.tgz even though the surrounding text instructs the user to pull the new version's archive first.
docs/source/deployment/kubernetes.md Mirrors the deploy/helm/README.md changes — drops OCI/repo-based FRAG commands in favour of .tgz installs. Same upgrade command inconsistency as in the README: line 289 uses aiq2-web-2.0.0.tgz while the prose says to use the new version's archive.
.secrets.baseline Mechanical update — adjusts a line number reference from 67 to 57 and refreshes the generated_at timestamp. No functional changes.

Sequence Diagram

sequenceDiagram
    participant User
    participant NGC as NGC Helm Repo<br/>(helm.ngc.nvidia.com)
    participant Helm
    participant K8s as Kubernetes Cluster

    User->>Helm: helm pull <NGC_URL>/aiq2-web-2.0.0.tgz<br/>--username / --password
    NGC-->>Helm: aiq2-web-2.0.0.tgz (downloaded locally)
    User->>Helm: helm show chart aiq2-web-2.0.0.tgz
    Helm-->>User: chart metadata (verify)

    User->>K8s: kubectl create namespace ns-aiq
    User->>K8s: kubectl create secret (aiq-credentials)
    User->>K8s: kubectl create secret (ngc-secret)

    User->>Helm: helm upgrade --install aiq aiq2-web-2.0.0.tgz<br/>-n ns-aiq --create-namespace<br/>--set imagePullSecrets
    Helm->>K8s: Deploy aiq-backend, aiq-frontend, aiq-postgres
    K8s-->>User: Pods Running
Loading

Last reviewed commit: "switch from helm fet..."

Copy link
Collaborator

@AjayThorve AjayThorve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AjayThorve AjayThorve merged commit 4a67205 into NVIDIA-AI-Blueprints:develop Mar 18, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants