Fix sentry cli pipeline #901
Conversation
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-water-056410803-901.westeurope.azurestaticapps.net |
amish1188
force-pushed
the
fix-sentry-cli-pipeline
branch
from
10c4299 to
180c11b
Compare
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-water-056410803-901.westeurope.azurestaticapps.net |
upload fix sourcemaps
amish1188
force-pushed
the
fix-sentry-cli-pipeline
branch
from
180c11b to
59660d2
Compare
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-water-056410803-901.westeurope.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-water-056410803-901.westeurope.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-water-056410803-901.westeurope.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-water-056410803-901.westeurope.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-water-056410803-901.westeurope.azurestaticapps.net |
1 similar comment
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-water-056410803-901.westeurope.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-water-056410803-901.westeurope.azurestaticapps.net |
There was a problem hiding this comment.
Pull request overview
This PR updates the Sentry CLI and browser SDK to modernize the sourcemap upload process in the CI/CD pipelines. The changes address breaking changes introduced in Sentry CLI v2.x by adopting the new sourcemaps inject and sourcemaps upload commands, and add platform-specific distribution identifiers to better track web vs mobile app releases in Sentry.
Changes:
- Updated
@sentry/clifrom v1.68.0 to v2.58.4 and@sentry/browserfrom v7.37.2 to v7.120.4 - Replaced manual Sentry CLI installation and release management with an npm script that uses the new v2 command structure
- Added platform-aware distribution identifiers (
-webvs-app) in the SentryService to distinguish between web and mobile app releases
Reviewed changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| src/app/modules/shared/services/logging/sentry.service.ts | Added getDistWithPlatform() method to append platform suffix to distribution identifier for better release tracking |
| pipelines/regobs-web-build-release.yml | Replaced Bash-based Sentry CLI installation with npm script, moved version file creation earlier, updated to use new sourcemap upload approach with platform-specific dist |
| pipelines/regobs-mobile-app-build-release.yml | Replaced Bash-based Sentry CLI with npm script for mobile app builds using -app dist suffix |
| package.json | Added sentry:sourcemaps script using new v2 CLI commands and updated package versions |
| package-lock.json | Updated lock file with new Sentry package versions and platform-specific CLI binaries |
| .gitignore | Added .sentryclirc to ignore Sentry CLI configuration file |
| .github/workflows/azure-static-web-apps-victorious-water-056410803.yml | Removed Sentry environment variables and sourcemap upload steps from develop branch workflow |
| "@ionic/cli": "^7.2.1", | ||
| "@lokalise/node-api": "^8.5.1", | ||
| "@sentry/cli": "^1.68.0", | ||
| "@sentry/cli": "^2.58.4", |
There was a problem hiding this comment.
The PR description mentions updating to sentry-cli version 3.0.0 and references the breaking changes for that version, but the actual version being installed is 2.58.4. While version 2.x does include the new sourcemaps commands, this discrepancy should be clarified. If 3.0.0 is the intended version, the package.json should be updated accordingly. If 2.58.4 is correct, the PR description should be updated to reflect this.
| "prettier:fix": "prettier --write src", | ||
| "update-headers": "ts-node --project tsconfig.npm-script.json headers-update-scripts/update-csp-and-pp-headers.ts" | ||
| "update-headers": "ts-node --project tsconfig.npm-script.json headers-update-scripts/update-csp-and-pp-headers.ts", | ||
| "sentry:sourcemaps": "cross-env-shell sentry-cli sourcemaps inject --org nve --project regobs-app ./www/browser && sentry-cli sourcemaps upload --release=$RELEASE --dist=$DIST --org nve --project regobs-app ./www/browser" |
There was a problem hiding this comment.
The new sentry:sourcemaps script no longer includes commit association (previously done with 'sentry-cli releases set-commits --local --ignore-missing'). While Sentry CLI v2's sourcemaps upload command automatically creates releases, it doesn't automatically associate git commits. Consider adding '--set-commits auto' flag to the sourcemaps upload command if you want to maintain git commit tracking in Sentry for better release tracking and suspect commit identification.
oppdaterer sentry cli versjon i pipelinen men også breaking changes endringer.
https://newreleases.io/project/github/getsentry/sentry-cli/release/3.0.0?utm_source=chatgpt.com