ビンゴ判定時にget apiを叩くように修正 #358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…na/bingo-judgement-get-api-call
TkymHrt
reviewed
Sep 5, 2025
Member
TkymHrt
left a comment
TkymHrt
left a comment
There was a problem hiding this comment.
動作とコード大丈夫そうでした！
1点だけコメントしてます。
view-admin/src/pages/_app.tsx
Outdated
| const definition = getMainDefinition(query); | ||
| return ( | ||
| definition.kind === "OperationDefinition" && | ||
| (definition as any).operation === "subscription" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
対応Issue
概要
ビンゴ判定時にsubscription通信で取得した値を使用しているが、たまに通信失敗しているので判定前にget apiを叩くように修正しました。
実装詳細
画面スクリーンショット等
テスト項目
備考