[refactor] ビンゴ判定モーダルの修正 #357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YosukeIida
approved these changes
Sep 2, 2025
| }; | ||
|
|
||
| const resetAll = () => { | ||
| finalizePendingInput(true); |
Collaborator
There was a problem hiding this comment.
JudgementModal.tsx resetAll関数のところで， finalizePendingInput(true); これって必要なの？
finalizePendingInput関数って，入力途中の値をビンゴ盤に「保存」する関数であってる？
この行なくてもいいのかもと思ったのですが，どうでしょう？？
そうすると，setBingoCard が2回呼ばれなくていいのなと思ったんだけど
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
対応Issue
概要
ビンゴ判定モーダルの選択機能の修正とESLint設定の更新
実装詳細
.vscode/settings.json
"source.fixAll.eslint": trueから"source.fixAll.eslint": "explicit"に変更。view-admin/src/components/common/JudgementModal/JudgementModal.tsx
hasSelection関数の削除（不要な型ガード）。getNextEditableCell関数の削除（自動移動機能を削除）。KEYPAD定数の追加（キーパッドのラベルを定数化）。finalizePendingInput関数の追加（保留中の入力を確定するロジック）。selectedCellのチェックを直接化）。画面スクリーンショット等
テスト項目