管理者が手動でアンケートを流す機能の実装 #345
Merged
管理者が手動でアンケートを流す機能の実装 #345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements a manual survey distribution feature for administrators to send survey prompts to users. The feature allows admins to configure and send Google Forms survey URLs to users via real-time modal prompts.
- Adds database schema for survey events with URL and activation status tracking
- Implements admin interface for survey URL configuration and distribution control
- Creates user-side modal system with session-based display restrictions
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| view-user/src/types/graphql.ts | Generated GraphQL types for events table and survey subscription |
| view-user/src/state/survey.ts | Recoil atom for tracking survey display state in user sessions |
| view-user/src/gql/events.gql | GraphQL subscription for real-time survey event updates |
| view-user/src/components/common/SurveyPromptModal/ | New modal component for displaying survey prompts to users |
| view-user/src/components/Layout/Layout.tsx | Integration of survey subscription and modal display logic |
| view-admin/src/type/graphql.ts | Generated GraphQL types for admin-side survey mutations |
| view-admin/src/pages/index.tsx | Admin interface for survey URL input and distribution controls |
| view-admin/src/gql/events.gql | GraphQL query and mutation for survey management |
| api/migrations/default/1720521696814_auto/up.sql | Database migration creating events table with survey fields |
| api/metadata/databases/default/tables/ | Hasura metadata configuration for events table GraphQL API |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
view-user/src/components/common/SurveyPromptModal/SurveyPromptModal.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This reverts commit 66a2a7a.
Collaborator
Author
|
大体copilotのは対応したはず |
This reverts commit 7a66d94.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| const Layout = (props: LayoutProps) => { | ||
| const router = useRouter(); | ||
| const t = props.language === "ja" ? ja : en; | ||
|
|
There was a problem hiding this comment.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ··
Suggested change
|
|
||
| const [mainColor, setMainColor] = useState(COLOR_PRESETS.DEFAULT_MAIN_COLOR); | ||
| const [subColor, setSubColor] = useState(COLOR_PRESETS.DEFAULT_SUB_COLOR); | ||
|
|
There was a problem hiding this comment.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ··
Suggested change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
対応Issue
概要
管理者（
view-admin）が任意のタイミングで「アンケート配信」を押すと、ユーザー（view-user）側にモーダルでGoogle Formsへの協力を促す機能を実装しました。ユーザー画面の番号サブスクとは分離した"軽量サブスク"で実現し、localStorageを使わずにセッション中1回だけ表示に抑制する仕様になっています。実装詳細
DB/Hasura
eventsテーブルにsurvey_urlとis_survey_activeの2列を追加（migration済み）public_events.yamlを追加してGraphQL APIを有効化view-admin
CreateEventSurvey) でアンケート状態を更新view-user
SubscribeLatestEventSurvey) でリアルタイム更新hasShownSurveyState) でセッション中の表示制御SurveyPromptModalの作成主要ファイル
api/metadata/databases/default/tables/public_events.yaml(新規)view-admin/src/gql/events.gql(新規)view-user/src/gql/events.gql(新規)view-user/src/state/survey.ts(新規)view-user/src/components/common/SurveyPromptModal/(新規)view-admin/src/pages/index.tsx(修正)view-user/src/components/Layout/Layout.tsx(修正)画面スクリーンショット等
管理者画面にアンケートURL入力欄と「配信する」「配信を停止する」ボタンを追加。ユーザー画面では配信時にモーダルが表示され、「回答する」でGoogle Formsが新しいタブで開き、「閉じる」または背景クリックでモーダルが閉じます。
テスト項目
備考