Skip to content

Conversation

@TkymHrt
Copy link
Member

@TkymHrt TkymHrt commented May 31, 2025

概要

  • JudgementModal のビンゴ判定の修正と、CSSスタイルの刷新を行いました。

実装詳細

  • 擬似的なビンゴカードを表示して、ユーザーが任意のセルに入力を行って判定を行えるようになりました。

画面スクリーンショット等

image image

テスト項目

  • テンキーで番号が入力できる。(1桁・2桁の追加、削除)
  • 正常に判定できる。

@TkymHrt TkymHrt requested review from YosukeIida and hikahana May 31, 2025 07:52
@github-actions github-actions bot added frontend bug Something isn't working labels May 31, 2025
Copy link
Collaborator

@hikahana hikahana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

コード雑レビュー。動作は見てないです

@TkymHrt TkymHrt requested a review from Copilot August 17, 2025 10:14

This comment was marked as outdated.

@TkymHrt TkymHrt requested a review from Copilot August 17, 2025 10:33

This comment was marked as outdated.

@TkymHrt TkymHrt requested a review from Copilot August 17, 2025 10:44
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

このPRはJudgementModalコンポーネントのビンゴ判定機能を完全に刷新し、ユーザビリティを大幅に改善します。以前の単純な数字入力から、5x5のビンゴカードを使った視覚的で直感的なインターフェースに変更されました。

  • 5x5ビンゴカードの実装と視覚的な判定機能
  • レスポンシブデザインとアクセシビリティ対応
  • 判定結果の視覚的フィードバック強化

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
JudgementModal.tsx ビンゴカード表示ロジック、セル入力処理、判定アルゴリズムの実装
JudgementModal.module.css ビンゴカード、レスポンシブデザイン、アニメーション効果のスタイル定義

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

const col = idx % BOARD_SIZE;
if (!isCenter(row, col)) return { row, col };
}
return from;

This comment was marked as off-topic.


const next = (inputValue + digit).slice(0, MAX_DIGIT_LENGTH);
const n = Number.parseInt(next, 10);
if (Number.isNaN(n) || n < 1 || n > MAX_BINGO_NUMBER) return;

This comment was marked as resolved.

if (!hasJudged || completedLines.length === 0) return false;
return (
completedLines.includes(`row-${row}` as LineId) ||
completedLines.includes(`col-${col}` as LineId) ||

This comment was marked as resolved.

}}
tabIndex={0}
role="button"
aria-label={`セル ${COL_HEADERS[c]}${r + 1} ${getCellText(r, c) || "空"}`}

This comment was marked as resolved.

@TkymHrt TkymHrt requested a review from hikahana August 17, 2025 10:57
Copy link
Collaborator

@hikahana hikahana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hikahana hikahana merged commit 180aa70 into develop Aug 18, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working frontend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants