-
Notifications
You must be signed in to change notification settings - Fork 3
[feat] FormListコンポーネント作成 #1783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] FormListコンポーネント作成 #1783
Conversation
izuizu0424
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
デザインはPC,モバイル共にOKでした
急なissue対応ありがとうございます
TkymHrt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
動作OKでした。コメントしています!
| export type FormItem = { | ||
| label: string; | ||
| content: string; | ||
| }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
とりあえず変更不可のプロパティを設定しておけば、表示は別途コンポーネント側で対応できるのかなと思いました。
| export type FormItem = { | |
| label: string; | |
| content: string; | |
| }; | |
| export type FormItem = { | |
| label: string; | |
| content: string; | |
| editable?: boolean; | |
| }; |
{item.editable === false && (
<span className="text-red-500 ml-6 text-xs">※変更できません</span>
)}There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
今日のgm2 mtで決まっただけど
ラベルずを作る
label.ts で,定数を宣言しておく.
こんな感じでlabel部分の定数を置いておいて、labelとdataを結合してFormItemで渡すことになったから、この修正ちょっと厳しいかな?
https://www.notion.so/nutfes-nutmeg/GM2-1cb41f19206380b682d9e6cf7fc710b5?pvs=4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
よく考えたらオプショナルだし、結合の時に一緒にやればいけるのか。
要確認でいきます!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
これ変更できないパターンの方が少ないから逆にします
TkymHrt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…/hikahana/1780-add-request-list-view
対応Issue
resolve #1780
概要
実装詳細
画面スクリーンショット等
テスト項目
備考
変更できません という部分があったがその実装は大変めんどう、、、
配列の要素をさらに追加する???
急ピッチで作成したのでpropsで渡すときは以下の形になっちゃう。。。
よしなに修正したいのですが、案あれば教えてください。。。。