[予算管理]CSVのダウンロードAPI作成 #927
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 22, 2025 15:11
Kubosaka
commented
Feb 22, 2025
Comment on lines
+141
to
+144
| // 2つのdsをUNION | ||
| sql := ds.Union(dsExceptItem).Order(goqu.I("id").Asc()) | ||
| query, _, err := sql.ToSQL() | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
局や部門だけ登録されている場合にも、予算0として、csvに書き出したいため、UNIONでselectの結果を結合
また、idでソートする（局ごとまとめたいため）
hikahana
reviewed
Feb 24, 2025
Comment on lines
208
to
210
| csvData := make([][]string, 0) | ||
| HEADER := []string{"局", "部門", "物品", "予算申請金額", "購入金額"} | ||
| csvData = append(csvData, HEADER) |
Collaborator
There was a problem hiding this comment.
Suggested change
| csvData := make([][]string, 0) | |
| HEADER := []string{"局", "部門", "物品", "予算申請金額", "購入金額"} | |
| csvData = append(csvData, HEADER) | |
| header := []string{"局", "部門", "物品", "予算申請金額", "購入金額"} | |
| csvData := [][]string{header} |
こんな感じでも定義できそうかも
| UpdatedAt time.Time `json:"updatedAt"` | ||
| } | ||
|
|
||
| type FinancialRecordDetail struct { |
Collaborator
There was a problem hiding this comment.
FinancialRecordData
で良いのでは？
| LeftJoin(goqu.I("buy_reports"), goqu.On(goqu.I("festival_items.id").Eq(goqu.I("buy_reports.festival_item_id")))). | ||
| GroupBy("financial_records.id") | ||
|
|
||
| // 予算・部門がないものを取得するds |
Collaborator
Author
There was a problem hiding this comment.
個人的にはコメントで説明があったほうが後々助かるかと思いますので必要かなって思います！
added 2 commits
February 24, 2025 15:39
Deploying finansu with
|
| Latest commit: |
b0a5a41
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5957f9d5.finansu.pages.dev |
| Branch Preview URL: | https://feat-kubosaka-budget-csv-dow.finansu.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
対応Issue
resolve #0
概要
/financial_records/csv/download?year={year}にブラウザでアクセスしたらcsvがダウンロードされます要件など
画面スクリーンショット等
予算_2025.csv
テスト項目
備考